[Nepomuk] [PATCH] Strigiservice Initial Run timing bug.

[Sebastian Trüg]

Hi Vishesh,

I would commit the patch without the notifications for now.
But I just realized yet another issue (sorry): QTime only measures a
single day. In theory the initial indexing can take more than an hour.
That means it could make more sense to measure the indexing time in
minutes only (let's face it, we do not care much about seconds and msecs
here). So maybe the best would be to remember the start of indexing as a
QDateTime and then sum up the minutes that have passed since then.

Cheers,
Sebastian

On 04/21/2010 05:15 PM, Vishesh Handa wrote:
> Sebastian.
> It turns out that you can't add seconds to a QTime which is recording
> the time (via start/restart). :-( So, I landed up using the method you
> suggested. I even fixed the bug you mentioned. I'm not sure whether we
> should provide a notification for suspension, and even if we should I
> don't think the Nepomuk::EventWatcher is the correct place. The current
> approach would only provide notifications during the initial run.
> However, I've provided both the versions. So, take your pick!
> 
> Does anyone think that a Notification should be shown when the indexing
> is paused/resumed? 
> 
> I've tested the patch, and it works perfectly. The previous version had
> 2 bugs - The QTime::addMsec syntax was wrong (It doesn't add them to the
> current object, but returns a new QTime instance), and the one mentioned
> above.
> 
> Please commit it, if you feel it's okay!
> 
> Thanks
> 
> - Vishesh Handa