[Nepomuk] [PATCH] Strigiservice Initial Run timing bug.

Vishesh Handa handa.vish at gmail.com
Wed Apr 21 17:15:24 CEST 2010


Sebastian.
It turns out that you can't add seconds to a QTime which is recording the
time (via start/restart). :-( So, I landed up using the method you
suggested. I even fixed the bug you mentioned. I'm not sure whether we
should provide a notification for suspension, and even if we should I don't
think the Nepomuk::EventWatcher is the correct place. The current approach
would only provide notifications during the initial run.
However, I've provided both the versions. So, take your pick!

Does anyone think that a Notification should be shown when the indexing is
paused/resumed?

I've tested the patch, and it works perfectly. The previous version had 2
bugs - The QTime::addMsec syntax was wrong (It doesn't add them to the
current object, but returns a new QTime instance), and the one mentioned
above.

Please commit it, if you feel it's okay!

Thanks

- Vishesh Handa
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20100421/d0ba4854/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: with_notification.diff
Type: text/x-patch
Size: 5626 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/nepomuk/attachments/20100421/d0ba4854/attachment.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: without_notification.diff
Type: text/x-patch
Size: 5425 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/nepomuk/attachments/20100421/d0ba4854/attachment-0001.diff 


More information about the Nepomuk mailing list