Review Request: Allow assets directories without trailing slash

Chris Browet cbro at semperpax.com
Tue Mar 13 17:11:26 UTC 2012



> On March 13, 2012, 4:59 p.m., BogDan Vatra wrote:
> > I had to revert the patch, because it makes the applications >x10 times slower.
> > I'll try to find another solution.

Yes, that's why I proposed to limit assets to path starting with "/assets". That actually speedup the startup even vs alpha3.


- Chris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103933/#review11361
-----------------------------------------------------------


On Feb. 11, 2012, 4:36 p.m., Chris Browet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103933/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2012, 4:36 p.m.)
> 
> 
> Review request for Necessitas and BogDan Vatra.
> 
> 
> Description
> -------
> 
> Allow assets directories without trailing slash, so avoiding to have to add a "/" when doing declarative subdir imports
> 
> 
> Diffs
> -----
> 
>   src/plugins/platforms/android/src/qandroidassetsfileenginehandler.cpp 3a3c678 
> 
> Diff: http://git.reviewboard.kde.org/r/103933/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chris Browet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/necessitas-devel/attachments/20120313/69ae7b25/attachment.html>


More information about the Necessitas-devel mailing list