[MassifVisualizer] Review Request 114891: Use KTabWidget instead of QTabWidget.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114891/#review52039
-----------------------------------------------------------


Hey,

this is not the case anymore when thinking about Qt5 / KF5. This review request can be discarded the, no?

- Milian Wolff


On Jan. 6, 2014, 10:43 p.m., Arnold Dumas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114891/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2014, 10:43 p.m.)
> 
> 
> Review request for Massif Visualizer and Milian Wolff.
> 
> 
> Repository: massif-visualizer
> 
> 
> Description
> -------
> 
> As mentionned on [1], KDE applications should not use Qt classes that have their KDE replacements. That's why I propose to replace QTabWidget by KTabWidget.
> 
> [1] http://techbase.kde.org/Policies/API_to_Avoid#Qt_classes_that_have_their_KDE_versions 
> 
> 
> Diffs
> -----
> 
>   app/mainwindow.ui 4fda1a6 
> 
> Diff: https://git.reviewboard.kde.org/r/114891/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arnold Dumas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/massif-visualizer/attachments/20140305/d00de448/attachment.html>