<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114891/">https://git.reviewboard.kde.org/r/114891/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hey,
this is not the case anymore when thinking about Qt5 / KF5. This review request can be discarded the, no?</pre>
<br />
<p>- Milian Wolff</p>
<br />
<p>On January 6th, 2014, 10:43 p.m. UTC, Arnold Dumas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Massif Visualizer and Milian Wolff.</div>
<div>By Arnold Dumas.</div>
<p style="color: grey;"><i>Updated Jan. 6, 2014, 10:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
massif-visualizer
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As mentionned on [1], KDE applications should not use Qt classes that have their KDE replacements. That's why I propose to replace QTabWidget by KTabWidget.
[1] http://techbase.kde.org/Policies/API_to_Avoid#Qt_classes_that_have_their_KDE_versions </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/mainwindow.ui <span style="color: grey">(4fda1a6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114891/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>