D29880: Avoid the need to set Qt::WA_DeleteOnClose on widgets using Marble

[Jan Niklas Hasse]

jhasse created this revision.
Herald added projects: Marble, KDE Edu.
Herald added subscribers: kde-edu, marble-devel.
jhasse requested review of this revision.

REVISION SUMMARY
  I've noticed that when using MarbleWidget in my app, closing the top level widget will no longer quit the QApplication. This is because the PopupLayer is still alive and has Qt::WA_QuitOnClose set, but is never closed.
  
  When unsetting it, MarbleWidget can be used in a window without having to set Qt::WA_DeleteOnClose. This allows the window to be created on the stack - also how it's done in Qt's examples: https://doc.qt.io/qt-5/qtwidgets-mainwindows-application-example.html

REPOSITORY
  R34 Marble

REVISION DETAIL
  https://phabricator.kde.org/D29880

AFFECTED FILES
  src/apps/marble-kde/kdemain.cpp
  src/apps/marble-qt/qtmain.cpp
  src/lib/marble/PopupItem.cpp

To: jhasse
Cc: marble-devel, kde-edu, fbampaloukas, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20201127/42d89df8/attachment.htm>