Review Request 130108: Introduced rotation the globe by right mouse button.
Dennis Nienhüser
nienhueser at kde.org
Sun Apr 30 08:46:24 UTC 2017
> On April 29, 2017, 11:01 vorm., Dennis Nienhüser wrote:
> > Sounds promising! We have switched to Phabricator for Code Review some time ago. Can you please file the same review request at https://phabricator.kde.org/differential/? Thanks!
Please follow up in https://phabricator.kde.org/D5650
I will close this review now.
- Dennis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130108/#review103155
-----------------------------------------------------------
On April 28, 2017, 6:29 vorm., VaL Doroshchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130108/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 6:29 vorm.)
>
>
> Review request for Marble and Adam Dabrowski.
>
>
> Repository: marble
>
>
> Description
> -------
>
> Also applied kinetic spinning like it is with changing position.
>
>
> Diffs
> -----
>
> src/lib/marble/MarbleAbstractPresenter.h ca3ad6c
> src/lib/marble/MarbleAbstractPresenter.cpp 1e93011
> src/lib/marble/MarbleInputHandler.cpp 837f725
> src/lib/marble/MarbleMap.h 1ae271d
> src/lib/marble/MarbleMap.cpp 866768e
> src/lib/marble/MarbleWidget.h 6f80fc6
> src/lib/marble/MarbleWidget.cpp e23f6fd
> src/lib/marble/ViewportParams.h 3571d8b
> src/lib/marble/ViewportParams.cpp 860efcc
> src/lib/marble/kineticmodel.h e95b6d4
> src/lib/marble/kineticmodel.cpp a20fdc7
>
> Diff: https://git.reviewboard.kde.org/r/130108/diff/
>
>
> Testing
> -------
>
> to-check: open a map and push the right button of mouse, the globe is going to be rotated by moving mouse by x and y axis.
> Also if you unclick the button, kinetic spinning will be enabled like it is when you use left mouse button.
>
>
> Thanks,
>
> VaL Doroshchuk
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20170430/fe75236a/attachment.html>
More information about the Marble-devel
mailing list