<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130108/">https://git.reviewboard.kde.org/r/130108/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 29th, 2017, 11:01 vorm. UTC, <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sounds promising! We have switched to Phabricator for Code Review some time ago. Can you please file the same review request at https://phabricator.kde.org/differential/? Thanks!</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Please follow up in https://phabricator.kde.org/D5650
I will close this review now.</p></pre>
<br />
<p>- Dennis</p>
<br />
<p>On April 28th, 2017, 6:29 vorm. UTC, VaL Doroshchuk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble and Adam Dabrowski.</div>
<div>By VaL Doroshchuk.</div>
<p style="color: grey;"><i>Updated April 28, 2017, 6:29 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also applied kinetic spinning like it is with changing position.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">to-check: open a map and push the right button of mouse, the globe is going to be rotated by moving mouse by x and y axis.
Also if you unclick the button, kinetic spinning will be enabled like it is when you use left mouse button.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/MarbleAbstractPresenter.h <span style="color: grey">(ca3ad6c)</span></li>
<li>src/lib/marble/MarbleAbstractPresenter.cpp <span style="color: grey">(1e93011)</span></li>
<li>src/lib/marble/MarbleInputHandler.cpp <span style="color: grey">(837f725)</span></li>
<li>src/lib/marble/MarbleMap.h <span style="color: grey">(1ae271d)</span></li>
<li>src/lib/marble/MarbleMap.cpp <span style="color: grey">(866768e)</span></li>
<li>src/lib/marble/MarbleWidget.h <span style="color: grey">(6f80fc6)</span></li>
<li>src/lib/marble/MarbleWidget.cpp <span style="color: grey">(e23f6fd)</span></li>
<li>src/lib/marble/ViewportParams.h <span style="color: grey">(3571d8b)</span></li>
<li>src/lib/marble/ViewportParams.cpp <span style="color: grey">(860efcc)</span></li>
<li>src/lib/marble/kineticmodel.h <span style="color: grey">(e95b6d4)</span></li>
<li>src/lib/marble/kineticmodel.cpp <span style="color: grey">(a20fdc7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130108/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>