D5396: Mismatch in parsed GeoDataDocument and GeoSceneGeodata in MarbleModelPrivate::assignFillColors(const QString &filePath)

[Abhinav Gangwar]

abhgangwar created this revision.

REVISION SUMMARY
  In method MarbleModelPrivate::assignFillColors(const QString &filePath):
  
  If the inner loop, which is iterating over the GeoSceneGeodata set in a layer, finds valid GeoSceneGeodata in the layer, the variable data becomes nonnull. If the data is nonnull, it causes the outer loop to exit even when the source file of GeoSceneData and path of parsed file don't match ( the condition data->sourceFile() == filePath in inner loop ). This results in applying wrong GeoSceneGeodata to a GeoDataDocument.

REPOSITORY
  R34 Marble

REVISION DETAIL
  https://phabricator.kde.org/D5396

AFFECTED FILES
  src/lib/marble/MarbleModel.cpp

To: abhgangwar, nienhueser, rahn
Cc: marble-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20170411/9f73360d/attachment.html>