[Differential] [Updated, 155 lines] D1420: [OS X] build in a more "traditional" way (for distribution systems like MacPorts, Fink etc) (and a bit of code clean-up)

Tue Dec 27 10:07:12 UTC 2016

rjvbb updated this revision to Diff 9378.
rjvbb added a comment.

  This updates the patch for git master/head.

  Tested with the MacPorts "port" available at
  https://github.com/RJVB/macstrop/tree/master/kf5/kf5-marble

  A few observations:

  - without the patch or with and built with -DAPPLE_STANDALONE_BUILD=ON I get a Marble.app application required but lacking the embedded libraries, and a marble-qt.app application which does contain them
  - neither of those builds finds the other resources it requires, which is undoubtedly to be expected given how I build and install (= for MacPorts)
  - with the patch and -DAPPLE_STANDALONE_BUILD=OFF both marble and marble-qt hang during initialisation, before the main window is rendered or drawn completely.

  That last point is very annoying and suggests I missed something that changed since 16.08.2 despite the fact that refactoring the patch was trivial.
  This hang also happens on Linux where my patch shouldn't do anything so something fishy is going on that I'm currently trying to pinpoint. I'm uploading the patch anyway in case somebody else already encountered something similar. (On Linux I just get the KWin frame containing a snapshot of whatever screen content it covered).

  On Linux I also see this on the calling terminal:

    No connection: Connection refused
    wlan2     Scan completed :
                        Signal: 51

    lo        Interface doesn't support scanning.

    eth4      Interface doesn't support scanning.

    wlan2     Scan completed :
                        Signal: 51

    lo        Interface doesn't support scanning.

    eth4      Interface doesn't support scanning.

    No connection: Connection refused

  which I cannot recall seeing before.

  A part of the backtrace on Linux:

    #0  _int_free (av=0x7ffff3819760 <main_arena>, p=0x1a1b680, have_lock=0) at malloc.c:3897
    #1  0x00007ffff773025f in deallocate (data=<optimised out>) at /opt/local/include/qt5/QtCore/qarraydata.h:222
    #2  ~QString (this=<optimised out>, __in_chrg=<optimised out>) at /opt/local/include/qt5/QtCore/qstring.h:1065
    #3  Marble::GeoDataCoordinates::lonToString (lon=lon at entry=-nan(0x8000000000000), notation=<optimised out>, 
        notation at entry=Marble::GeoDataCoordinates::DMS, unit=unit at entry=Marble::GeoDataCoordinates::Degree, 
        precision=<optimised out>, precision at entry=-1, format=format at entry=103 'g')
        at /opt/local/var/lnxports/build/_opt_local_site-ports_kf5_kf5-marble/kf5-marble/work/marble-16.12.0/src/lib/marble/geodata/data/GeoDataCoordinates.cpp:519
    #4  0x00007fffc86e3d1f in Marble::GraticulePlugin::renderLongitudeLines (this=<optimised out>, 
        painter=0x7fffffffb620, viewLatLonAltBox=..., step=inf, skipStep=0, northPolarGap=30, southPolarGap=30, 
        labelPositionFlags=...)
        at /opt/local/var/lnxports/build/_opt_local_site-ports_kf5_kf5-marble/kf5-marble/work/marble-16.12.0/src/plugins/render/graticule/GraticulePlugin.cpp:621
    #5  0x00007fffc86e4d63 in Marble::GraticulePlugin::renderGrid (this=this at entry=0xbc5dc0, 
        painter=painter at entry=0x7fffffffb620, viewport=viewport at entry=0x80c650, equatorCirclePen=..., 
        tropicsCirclePen=..., gridCirclePen=...)
        at /opt/local/var/lnxports/build/_opt_local_site-ports_kf5_kf5-marble/kf5-marble/work/marble-16.12.0/src/plugins/render/graticule/GraticulePlugin.cpp:387
    #6  0x00007fffc86e55be in Marble::GraticulePlugin::render (this=0xbc5dc0, painter=0x7fffffffb620, 
        viewport=0x80c650, renderPos=..., layer=<optimised out>)
        at /opt/local/var/lnxports/build/_opt_local_site-ports_kf5_kf5-marble/kf5-marble/work/marble-16.12.0/src/plugins/render/graticule/GraticulePlugin.cpp:286
    #7  0x00007ffff78992cd in Marble::LayerManager::renderLayers (this=0x80c670, painter=painter at entry=0x7fffffffb620, 
        viewport=0x80c650)
        at /opt/local/var/lnxports/build/_opt_local_site-ports_kf5_kf5-marble/kf5-marble/work/marble-16.12.0/src/lib/marble/LayerManager.cpp:181
    #8  0x00007ffff77fcd92 in Marble::MarbleMap::paint (this=0x803480, painter=..., dirtyRect=...)
        at /opt/local/var/lnxports/build/_opt_local_site-ports_kf5_kf5-marble/kf5-marble/work/marble-16.12.0/src/lib/marble/MarbleMap.cpp:842
    #9  0x00007ffff77ed335 in Marble::MarbleWidget::paintEvent (this=0x7df2b0, evt=0x7fffffffb910)
        at /opt/local/var/lnxports/build/_opt_local_site-ports_kf5_kf5-marble/kf5-marble/work/marble-16.12.0/src/lib/marble/MarbleWidget.cpp:709
    #10 0x00007ffff5063b68 in QWidget::event (this=0x7df2b0, event=0x7fffffffb910)
        at /opt/local/var/lnxports/build/_opt_local_site-ports_aqua_qt5-kde-devel/qt5-kde-devel/work/qt-everywhere-opensource-src-5.6.2/qtbase/src/widgets/kernel/qwidget.cpp:9117

REPOSITORY
  R34 Marble

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1420?vs=9377&id=9378

REVISION DETAIL
  https://phabricator.kde.org/D1420

AFFECTED FILES
  CMakeLists.txt
  data/CMakeLists.txt
  examples/cpp/marble-game/GameMainWindow.cpp
  src/CMakeLists.txt
  src/apps/marble-kde/CMakeLists.txt
  src/apps/marble-qt/CMakeLists.txt
  src/apps/marble-qt/QtMainWindow.cpp
  src/apps/marble-qt/qtmain.cpp
  src/lib/astro/CMakeLists.txt
  src/lib/marble/AbstractFloatItem.cpp
  src/lib/marble/CMakeLists.txt
  src/lib/marble/MapThemeSortFilterProxyModel.cpp
  src/lib/marble/MapViewItemDelegate.cpp
  src/lib/marble/MapViewWidget.cpp
  src/lib/marble/MarbleDirs.cpp
  src/lib/marble/QtMarbleConfigDialog.cpp
  src/lib/marble/StyleBuilder.cpp
  src/lib/marble/declarative/MarbleQuickItem.cpp
  src/lib/marble/declarative/Settings.cpp
  src/lib/marble/geodata/data/GeoDataLabelStyle.cpp
  src/plugins/render/foursquare/FoursquarePlugin.cpp
  src/plugins/render/graticule/GraticulePlugin.cpp
  src/plugins/render/measure/MeasureToolPlugin.cpp
  src/plugins/render/weather/WeatherItem.cpp
  src/plugins/runner/gpx/CMakeLists.txt
  src/plugins/runner/json/CMakeLists.txt
  src/plugins/runner/kml/CMakeLists.txt
  src/plugins/runner/shp/CMakeLists.txt
  tests/CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rjvbb, #marble
Cc: rahn, nienhueser, kaning, mnafees, shentey, chaz6, dkolozsvari, cmihalache, marble-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20161227/0d4f6fe4/attachment.html>