<table><tr><td style="">rjvbb updated this revision to Diff 9378.<br />rjvbb added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1420" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>This updates the patch for git master/head.</p>
<p>Tested with the MacPorts "port" available at<br />
<a href="https://github.com/RJVB/macstrop/tree/master/kf5/kf5-marble" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/RJVB/macstrop/tree/master/kf5/kf5-marble</a></p>
<p>A few observations:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">without the patch or with and built with -DAPPLE_STANDALONE_BUILD=ON I get a Marble.app application required but lacking the embedded libraries, and a marble-qt.app application which does contain them</li>
<li class="remarkup-list-item">neither of those builds finds the other resources it requires, which is undoubtedly to be expected given how I build and install (= for MacPorts)</li>
<li class="remarkup-list-item">with the patch and -DAPPLE_STANDALONE_BUILD=OFF both marble and marble-qt hang during initialisation, before the main window is rendered or drawn completely.</li>
</ul>
<p>That last point is very annoying and suggests I missed something that changed since 16.08.2 despite the fact that refactoring the patch was trivial.<br />
This hang also happens on Linux where my patch shouldn't do anything so something fishy is going on that I'm currently trying to pinpoint. I'm uploading the patch anyway in case somebody else already encountered something similar. (On Linux I just get the KWin frame containing a snapshot of whatever screen content it covered).</p>
<p>On Linux I also see this on the calling terminal:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">No connection: Connection refused
wlan2 Scan completed :
Signal: 51
lo Interface doesn't support scanning.
eth4 Interface doesn't support scanning.
wlan2 Scan completed :
Signal: 51
lo Interface doesn't support scanning.
eth4 Interface doesn't support scanning.
No connection: Connection refused</pre></div>
<p>which I cannot recall seeing before.</p>
<p>A part of the backtrace on Linux:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">#0 _int_free (av=0x7ffff3819760 <main_arena>, p=0x1a1b680, have_lock=0) at malloc.c:3897
#1 0x00007ffff773025f in deallocate (data=<optimised out>) at /opt/local/include/qt5/QtCore/qarraydata.h:222
#2 ~QString (this=<optimised out>, __in_chrg=<optimised out>) at /opt/local/include/qt5/QtCore/qstring.h:1065
#3 Marble::GeoDataCoordinates::lonToString (lon=lon@entry=-nan(0x8000000000000), notation=<optimised out>,
notation@entry=Marble::GeoDataCoordinates::DMS, unit=unit@entry=Marble::GeoDataCoordinates::Degree,
precision=<optimised out>, precision@entry=-1, format=format@entry=103 'g')
at /opt/local/var/lnxports/build/_opt_local_site-ports_kf5_kf5-marble/kf5-marble/work/marble-16.12.0/src/lib/marble/geodata/data/GeoDataCoordinates.cpp:519
#4 0x00007fffc86e3d1f in Marble::GraticulePlugin::renderLongitudeLines (this=<optimised out>,
painter=0x7fffffffb620, viewLatLonAltBox=..., step=inf, skipStep=0, northPolarGap=30, southPolarGap=30,
labelPositionFlags=...)
at /opt/local/var/lnxports/build/_opt_local_site-ports_kf5_kf5-marble/kf5-marble/work/marble-16.12.0/src/plugins/render/graticule/GraticulePlugin.cpp:621
#5 0x00007fffc86e4d63 in Marble::GraticulePlugin::renderGrid (this=this@entry=0xbc5dc0,
painter=painter@entry=0x7fffffffb620, viewport=viewport@entry=0x80c650, equatorCirclePen=...,
tropicsCirclePen=..., gridCirclePen=...)
at /opt/local/var/lnxports/build/_opt_local_site-ports_kf5_kf5-marble/kf5-marble/work/marble-16.12.0/src/plugins/render/graticule/GraticulePlugin.cpp:387
#6 0x00007fffc86e55be in Marble::GraticulePlugin::render (this=0xbc5dc0, painter=0x7fffffffb620,
viewport=0x80c650, renderPos=..., layer=<optimised out>)
at /opt/local/var/lnxports/build/_opt_local_site-ports_kf5_kf5-marble/kf5-marble/work/marble-16.12.0/src/plugins/render/graticule/GraticulePlugin.cpp:286
#7 0x00007ffff78992cd in Marble::LayerManager::renderLayers (this=0x80c670, painter=painter@entry=0x7fffffffb620,
viewport=0x80c650)
at /opt/local/var/lnxports/build/_opt_local_site-ports_kf5_kf5-marble/kf5-marble/work/marble-16.12.0/src/lib/marble/LayerManager.cpp:181
#8 0x00007ffff77fcd92 in Marble::MarbleMap::paint (this=0x803480, painter=..., dirtyRect=...)
at /opt/local/var/lnxports/build/_opt_local_site-ports_kf5_kf5-marble/kf5-marble/work/marble-16.12.0/src/lib/marble/MarbleMap.cpp:842
#9 0x00007ffff77ed335 in Marble::MarbleWidget::paintEvent (this=0x7df2b0, evt=0x7fffffffb910)
at /opt/local/var/lnxports/build/_opt_local_site-ports_kf5_kf5-marble/kf5-marble/work/marble-16.12.0/src/lib/marble/MarbleWidget.cpp:709
#10 0x00007ffff5063b68 in QWidget::event (this=0x7df2b0, event=0x7fffffffb910)
at /opt/local/var/lnxports/build/_opt_local_site-ports_aqua_qt5-kde-devel/qt5-kde-devel/work/qt-everywhere-opensource-src-5.6.2/qtbase/src/widgets/kernel/qwidget.cpp:9117</pre></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R34 Marble</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D1420?vs=9377&id=9378" rel="noreferrer">https://phabricator.kde.org/D1420?vs=9377&id=9378</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1420" rel="noreferrer">https://phabricator.kde.org/D1420</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
data/CMakeLists.txt<br />
examples/cpp/marble-game/GameMainWindow.cpp<br />
src/CMakeLists.txt<br />
src/apps/marble-kde/CMakeLists.txt<br />
src/apps/marble-qt/CMakeLists.txt<br />
src/apps/marble-qt/QtMainWindow.cpp<br />
src/apps/marble-qt/qtmain.cpp<br />
src/lib/astro/CMakeLists.txt<br />
src/lib/marble/AbstractFloatItem.cpp<br />
src/lib/marble/CMakeLists.txt<br />
src/lib/marble/MapThemeSortFilterProxyModel.cpp<br />
src/lib/marble/MapViewItemDelegate.cpp<br />
src/lib/marble/MapViewWidget.cpp<br />
src/lib/marble/MarbleDirs.cpp<br />
src/lib/marble/QtMarbleConfigDialog.cpp<br />
src/lib/marble/StyleBuilder.cpp<br />
src/lib/marble/declarative/MarbleQuickItem.cpp<br />
src/lib/marble/declarative/Settings.cpp<br />
src/lib/marble/geodata/data/GeoDataLabelStyle.cpp<br />
src/plugins/render/foursquare/FoursquarePlugin.cpp<br />
src/plugins/render/graticule/GraticulePlugin.cpp<br />
src/plugins/render/measure/MeasureToolPlugin.cpp<br />
src/plugins/render/weather/WeatherItem.cpp<br />
src/plugins/runner/gpx/CMakeLists.txt<br />
src/plugins/runner/json/CMakeLists.txt<br />
src/plugins/runner/kml/CMakeLists.txt<br />
src/plugins/runner/shp/CMakeLists.txt<br />
tests/CMakeLists.txt</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>rjvbb, Marble<br /><strong>Cc: </strong>rahn, nienhueser, kaning, mnafees, shentey, chaz6, dkolozsvari, cmihalache, marble-devel<br /></div>