[Marble-devel] Review Request 125596: Rename libastro to libastro-qt5 in case we build against Qt5. This makes also libastro co-installable

Raymond Wooninck tittiatcoke at gmail.com
Sun Oct 11 15:47:50 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125596/
-----------------------------------------------------------

Review request for Marble and Dennis Nienhüser.


Repository: marble


Description
-------

Marble can be build either against Qt4 or Qt5. At this moment only libmarblewidget is co-installable as that with Qt5, the library is renamed to libmarblewidget-qt5.  This patch does the same thing for libastro, as that libmarblewidget depends on libastro. 

Libmarblewidget is a dependency for libkgeomap and digikam, which at this moment are still Qt4 based.


Diffs
-----

  CMakeLists.txt 98f024d 
  src/apps/behaim/CMakeLists.txt d40e4a1 
  src/apps/marble-kde/CMakeLists.txt e6c2386 
  src/apps/marble-maps/CMakeLists.txt ed35539 
  src/apps/marble-qt/CMakeLists.txt 4d3e91c 
  src/lib/astro/CMakeLists.txt 17a59b8 
  src/lib/marble/CMakeLists.txt 28d6075 
  src/plugins/render/eclipses/CMakeLists.txt 754c980 
  src/plugins/render/satellites/CMakeLists.txt 66a7cad 
  src/plugins/render/stars/CMakeLists.txt 1afb81f 
  tools/osm-sisyphus/CMakeLists.txt 8a1618b 

Diff: https://git.reviewboard.kde.org/r/125596/diff/


Testing
-------

Patch applies cleanly and Marble builds fine.  On Qt5, we have now libastro-qt5 and libmarblewidget-qt5 depends correctly on libastro-qt5


Thanks,

Raymond Wooninck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20151011/0272cfdc/attachment.html>


More information about the Marble-devel mailing list