<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125596/">https://git.reviewboard.kde.org/r/125596/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble and Dennis Nienhüser.</div>
<div>By Raymond Wooninck.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Marble can be build either against Qt4 or Qt5. At this moment only libmarblewidget is co-installable as that with Qt5, the library is renamed to libmarblewidget-qt5. This patch does the same thing for libastro, as that libmarblewidget depends on libastro. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Libmarblewidget is a dependency for libkgeomap and digikam, which at this moment are still Qt4 based.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Patch applies cleanly and Marble builds fine. On Qt5, we have now libastro-qt5 and libmarblewidget-qt5 depends correctly on libastro-qt5</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(98f024d)</span></li>
<li>src/apps/behaim/CMakeLists.txt <span style="color: grey">(d40e4a1)</span></li>
<li>src/apps/marble-kde/CMakeLists.txt <span style="color: grey">(e6c2386)</span></li>
<li>src/apps/marble-maps/CMakeLists.txt <span style="color: grey">(ed35539)</span></li>
<li>src/apps/marble-qt/CMakeLists.txt <span style="color: grey">(4d3e91c)</span></li>
<li>src/lib/astro/CMakeLists.txt <span style="color: grey">(17a59b8)</span></li>
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(28d6075)</span></li>
<li>src/plugins/render/eclipses/CMakeLists.txt <span style="color: grey">(754c980)</span></li>
<li>src/plugins/render/satellites/CMakeLists.txt <span style="color: grey">(66a7cad)</span></li>
<li>src/plugins/render/stars/CMakeLists.txt <span style="color: grey">(1afb81f)</span></li>
<li>tools/osm-sisyphus/CMakeLists.txt <span style="color: grey">(8a1618b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125596/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>