[Marble-devel] Review Request 123538: Implementing the Gall-Peters Projection

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123538/#review80810
-----------------------------------------------------------


Where can I get map-gallPeters.png from? It's referenced in the code, but not attached (binary files like images do not appear in patches here, but need to be attached separately).


src/lib/marble/MarbleGlobal.h (line 54)
<https://git.reviewboard.kde.org/r/123538/#comment55396>

    Given the comment I'd switch the VerticalPerspective and GallPeters enum values above


- Dennis Nienhüser


On April 29, 2015, 12:46 p.m., SIlvia Pripoae wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123538/
> -----------------------------------------------------------
> 
> (Updated April 29, 2015, 12:46 p.m.)
> 
> 
> Review request for Marble, Calin Cruceru and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch adds the Gall-Peters projection.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/CMakeLists.txt f448f84 
>   src/lib/marble/DownloadRegion.cpp 8cef270 
>   src/lib/marble/GallPetersScanlineTextureMapper.h PRE-CREATION 
>   src/lib/marble/GallPetersScanlineTextureMapper.cpp PRE-CREATION 
>   src/lib/marble/MapViewWidget.h 12ff6f9 
>   src/lib/marble/MapViewWidget.cpp 4d8f9f6 
>   src/lib/marble/MapViewWidget.ui af33e8f 
>   src/lib/marble/MarbleGlobal.h a75d228 
>   src/lib/marble/ScanlineTextureMapperContext.h 54fab80 
>   src/lib/marble/ServerLayout.cpp 5049998 
>   src/lib/marble/TileId.cpp 1227441 
>   src/lib/marble/ViewportParams.cpp bca8ea9 
>   src/lib/marble/geodata/handlers/dgml/DgmlProjectionTagHandler.cpp 9ab9dbf 
>   src/lib/marble/geodata/scene/GeoSceneTiled.h 56173ff 
>   src/lib/marble/geodata/writers/dgml/DgmlTextureTagWriter.cpp 4d165cd 
>   src/lib/marble/layers/TextureLayer.cpp 9d8976f 
>   src/lib/marble/projections/GallPetersProjection.h PRE-CREATION 
>   src/lib/marble/projections/GallPetersProjection.cpp PRE-CREATION 
>   src/plugins/declarative/MarbleDeclarativeWidget.cpp e39def6 
> 
> Diff: https://git.reviewboard.kde.org/r/123538/diff/
> 
> 
> Testing
> -------
> 
> It works as expected in Plain Map, but the textures for Atlas and Satellite View don't show properly.
> 
> 
> Thanks,
> 
> SIlvia Pripoae
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150525/3b63fe50/attachment.html>