<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123538/">https://git.reviewboard.kde.org/r/123538/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Where can I get map-gallPeters.png from? It's referenced in the code, but not attached (binary files like images do not appear in patches here, but need to be attached separately).</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/123538/diff/2/?file=364567#file364567line54" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/MarbleGlobal.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">enum Projection {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">53</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// </span><span class="cs">NOTE</span><span class="c1">: MarbleWidget::setProjection(int) relies on VerticalPerspective being the last</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">54</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// </span><span class="cs">NOTE</span><span class="c1">: MarbleWidget::setProjection(int) relies on VerticalPerspective being the last</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Given the comment I'd switch the VerticalPerspective and GallPeters enum values above</p></pre>
</div>
</div>
<br />
<p>- Dennis Nienhüser</p>
<br />
<p>On April 29th, 2015, 12:46 p.m. UTC, SIlvia Pripoae wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble, Calin Cruceru and Torsten Rahn.</div>
<div>By SIlvia Pripoae.</div>
<p style="color: grey;"><i>Updated April 29, 2015, 12:46 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch adds the Gall-Peters projection.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It works as expected in Plain Map, but the textures for Atlas and Satellite View don't show properly.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(f448f84)</span></li>
<li>src/lib/marble/DownloadRegion.cpp <span style="color: grey">(8cef270)</span></li>
<li>src/lib/marble/GallPetersScanlineTextureMapper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/GallPetersScanlineTextureMapper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MapViewWidget.h <span style="color: grey">(12ff6f9)</span></li>
<li>src/lib/marble/MapViewWidget.cpp <span style="color: grey">(4d8f9f6)</span></li>
<li>src/lib/marble/MapViewWidget.ui <span style="color: grey">(af33e8f)</span></li>
<li>src/lib/marble/MarbleGlobal.h <span style="color: grey">(a75d228)</span></li>
<li>src/lib/marble/ScanlineTextureMapperContext.h <span style="color: grey">(54fab80)</span></li>
<li>src/lib/marble/ServerLayout.cpp <span style="color: grey">(5049998)</span></li>
<li>src/lib/marble/TileId.cpp <span style="color: grey">(1227441)</span></li>
<li>src/lib/marble/ViewportParams.cpp <span style="color: grey">(bca8ea9)</span></li>
<li>src/lib/marble/geodata/handlers/dgml/DgmlProjectionTagHandler.cpp <span style="color: grey">(9ab9dbf)</span></li>
<li>src/lib/marble/geodata/scene/GeoSceneTiled.h <span style="color: grey">(56173ff)</span></li>
<li>src/lib/marble/geodata/writers/dgml/DgmlTextureTagWriter.cpp <span style="color: grey">(4d165cd)</span></li>
<li>src/lib/marble/layers/TextureLayer.cpp <span style="color: grey">(9d8976f)</span></li>
<li>src/lib/marble/projections/GallPetersProjection.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/projections/GallPetersProjection.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/declarative/MarbleDeclarativeWidget.cpp <span style="color: grey">(e39def6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123538/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>