[Marble-devel] Review Request 123866: Add KmlLabelTagWriter
Dennis Nienhüser
earthwings at gentoo.org
Mon May 25 11:52:01 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123866/#review80807
-----------------------------------------------------------
Ship it!
Looks fine, thanks.
src/lib/marble/geodata/writers/kml/KmlColorStyleTagWriter.h (line 34)
<https://git.reviewboard.kde.org/r/123866/#comment55395>
Please keep, it's meant in the sense of https://en.wikipedia.org/wiki/If_and_only_if
- Dennis Nienhüser
On May 23, 2015, 10:53 p.m., Constantin Mihalache wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123866/
> -----------------------------------------------------------
>
> (Updated May 23, 2015, 10:53 p.m.)
>
>
> Review request for Marble.
>
>
> Repository: marble
>
>
> Description
> -------
>
> Implemented the KmlLabelTagWriter which is useful for writing styles for TextAnnotations.
>
>
> Diffs
> -----
>
> src/lib/marble/geodata/CMakeLists.txt fe22e24
> src/lib/marble/geodata/writers/kml/KmlColorStyleTagWriter.h 62be099
> src/lib/marble/geodata/writers/kml/KmlColorStyleTagWriter.cpp 2696750
> src/lib/marble/geodata/writers/kml/KmlLabelStyleTagWriter.h PRE-CREATION
> src/lib/marble/geodata/writers/kml/KmlLabelStyleTagWriter.cpp PRE-CREATION
> tests/data/PlacemarkTest.kml PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/123866/diff/
>
>
> Testing
> -------
>
> It works as expected.
>
>
> Thanks,
>
> Constantin Mihalache
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150525/8503ac05/attachment.html>
More information about the Marble-devel
mailing list