[Marble-devel] Review Request 123866: Add KmlLabelTagWriter

[Constantin Mihalache]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123866/
-----------------------------------------------------------

(Updated May 23, 2015, 10:53 p.m.)


Review request for Marble.


Changes
-------

Solved mentioned issues.
Implemented defaultColor() virtual method.
Added unit test .kml file for placemarks (and labelStyle of course).
All tests pass with no errors.


Repository: marble


Description
-------

Implemented the KmlLabelTagWriter which is useful for writing styles for TextAnnotations.


Diffs (updated)
-----

  src/lib/marble/geodata/CMakeLists.txt fe22e24 
  src/lib/marble/geodata/writers/kml/KmlColorStyleTagWriter.h 62be099 
  src/lib/marble/geodata/writers/kml/KmlColorStyleTagWriter.cpp 2696750 
  src/lib/marble/geodata/writers/kml/KmlLabelStyleTagWriter.h PRE-CREATION 
  src/lib/marble/geodata/writers/kml/KmlLabelStyleTagWriter.cpp PRE-CREATION 
  tests/data/PlacemarkTest.kml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/123866/diff/


Testing
-------

It works as expected.


Thanks,

Constantin Mihalache

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150523/73a0ac42/attachment.html>