[Marble-devel] Review Request 123180: Improved ground overlays

[Adam Dabrowski]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123180/
-----------------------------------------------------------

(Updated March 31, 2015, 7:53 a.m.)


Review request for Marble.


Repository: marble


Description
-------

Improved ground overlays: performance, transluscency, visibility

-Performance improved by replacing object construction in critical part of the code with static calls
-Added transluscency based on alpha of pixels in overlay icon
-Added testing for global visibility before rendering overlay


Diffs (updated)
-----

  src/lib/marble/MergedLayerDecorator.cpp fd3b6e9 
  src/lib/marble/geodata/data/GeoDataLatLonBox.h 5505090 
  src/lib/marble/geodata/data/GeoDataLatLonBox.cpp 5dd7834 

Diff: https://git.reviewboard.kde.org/r/123180/diff/


Testing
-------

Ran with several images of ground overlays, tested performance with QElapsedTimer. 

All three aspect work and the performance is improved almost 3x on my machine - tested by rotating and moving the overlay around.


Thanks,

Adam Dabrowski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150331/bda383db/attachment.html>