[Marble-devel] Review Request 123180: Improved ground overlays

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123180/#review78218
-----------------------------------------------------------


* visibility: looks good to me, I'll push that on your behalf directly
* translucency: seems fine also, but I'd wait for someone else (Bernhard?) with more experience in the blending/tiling areas for acknowledgement
* performance: good catch, looks reasonable. Similarly I'd give others a chance to review the API additions before pushing


src/lib/marble/geodata/data/GeoDataLatLonBox.h (line 110)
<https://git.reviewboard.kde.org/r/123180/#comment53595>

    Given the possible confusion whether input and output are radians or degrees I'd favor separate doxygen documentation for this and the two next methods.


- Dennis Nienhüser


On March 30, 2015, 11:11 a.m., Adam Dabrowski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123180/
> -----------------------------------------------------------
> 
> (Updated March 30, 2015, 11:11 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Improved ground overlays: performance, transluscency, visibility
> 
> -Performance improved by replacing object construction in critical part of the code with static calls
> -Added transluscency based on alpha of pixels in overlay icon
> -Added testing for global visibility before rendering overlay
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/MergedLayerDecorator.cpp fd3b6e9 
>   src/lib/marble/geodata/data/GeoDataLatLonBox.h 5505090 
>   src/lib/marble/geodata/data/GeoDataLatLonBox.cpp 5dd7834 
> 
> Diff: https://git.reviewboard.kde.org/r/123180/diff/
> 
> 
> Testing
> -------
> 
> Ran with several images of ground overlays, tested performance with QElapsedTimer. 
> 
> All three aspect work and the performance is improved almost 3x on my machine - tested by rotating and moving the overlay around.
> 
> 
> Thanks,
> 
> Adam Dabrowski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150330/92058a46/attachment.html>