[Marble-devel] Review Request 123001: Introduced more intuitive cursors for the Annotate plugin.

[Dávid Kolozsvári]

> On March 21, 2015, 10:35 a.m., Torsten Rahn wrote:
> > Could you add another patch which makes it resizable vertically or horizontally at the edges (plus a fitting vertically or horizontally resizing cursor)

Of course.


- Dávid


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123001/#review77871
-----------------------------------------------------------


On March 18, 2015, 2:50 a.m., Dávid Kolozsvári wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123001/
> -----------------------------------------------------------
> 
> (Updated March 18, 2015, 2:50 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Up until now, the same cursor was used for almost every action related to every item(Placemark, Polygon, Polyline, GroundOverlay) in the Annotate plugin. Because of this, the user coudn't see what was draggable, what was resizable, what was movable, etc. 
> For example, my initial task was to implement an interactive resize functionality for the GroundOverlay item, but after playing around with it I realized that it was already resizable if I was dragging the corners, but it had no signs of this.
> 
> The changes I made introduced a separate cursor to show:
> -when the user is hovering over an items body, which intuitively says "you can move it"
> -when the user is hovering over a node
> -when the user is hovering over the GroundOverlay's corners, thus showing that he can resize it
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/annotate/AnnotatePlugin.cpp fb49eac 
>   src/plugins/render/annotate/AreaAnnotation.cpp 26ee84f 
>   src/plugins/render/annotate/GroundOverlayFrame.cpp 0ce5fed 
>   src/plugins/render/annotate/PlacemarkTextAnnotation.cpp 2960b9a 
>   src/plugins/render/annotate/PolylineAnnotation.cpp 69e8b66 
>   src/plugins/render/annotate/SceneGraphicsItem.h cba3a65 
> 
> Diff: https://git.reviewboard.kde.org/r/123001/diff/
> 
> 
> Testing
> -------
> 
> Testing was done by me and one of my friend. Works fine, it is surely more intuitive :)
> 
> 
> Thanks,
> 
> Dávid Kolozsvári
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150321/9dbfeffb/attachment.html>