<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123001/">https://git.reviewboard.kde.org/r/123001/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 21st, 2015, 10:35 a.m. UTC, <b>Torsten Rahn</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Could you add another patch which makes it resizable vertically or horizontally at the edges (plus a fitting vertically or horizontally resizing cursor)</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Of course.</p></pre>
<br />
<p>- Dávid</p>
<br />
<p>On March 18th, 2015, 2:50 a.m. UTC, Dávid Kolozsvári wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Dávid Kolozsvári.</div>
<p style="color: grey;"><i>Updated March 18, 2015, 2:50 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Up until now, the same cursor was used for almost every action related to every item(Placemark, Polygon, Polyline, GroundOverlay) in the Annotate plugin. Because of this, the user coudn't see what was draggable, what was resizable, what was movable, etc.
For example, my initial task was to implement an interactive resize functionality for the GroundOverlay item, but after playing around with it I realized that it was already resizable if I was dragging the corners, but it had no signs of this.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The changes I made introduced a separate cursor to show:
-when the user is hovering over an items body, which intuitively says "you can move it"
-when the user is hovering over a node
-when the user is hovering over the GroundOverlay's corners, thus showing that he can resize it</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Testing was done by me and one of my friend. Works fine, it is surely more intuitive :)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/render/annotate/AnnotatePlugin.cpp <span style="color: grey">(fb49eac)</span></li>
<li>src/plugins/render/annotate/AreaAnnotation.cpp <span style="color: grey">(26ee84f)</span></li>
<li>src/plugins/render/annotate/GroundOverlayFrame.cpp <span style="color: grey">(0ce5fed)</span></li>
<li>src/plugins/render/annotate/PlacemarkTextAnnotation.cpp <span style="color: grey">(2960b9a)</span></li>
<li>src/plugins/render/annotate/PolylineAnnotation.cpp <span style="color: grey">(69e8b66)</span></li>
<li>src/plugins/render/annotate/SceneGraphicsItem.h <span style="color: grey">(cba3a65)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123001/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>