[Marble-devel] Review Request 106988: Avoid some QAction-related warnings in the KDE version

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/106988/
-----------------------------------------------------------

(Updated Juni 27, 2015, 11:08 vorm.)


Status
------

This change has been discarded.


Review request for Marble.


Repository: marble


Description
-------

API change: remove RenderPlugin::action()

With this patch, the actions are created outside of the plugins which is more flexible.
In the KDE version, for instance, creation of KActions (rather than QActions) avoids 'marble(26988)/kdeui (kdelibs): Attempt to use QAction "" with KXMLGUIFactory!' warnings.


Diffs
-----

  src/QtMainWindow.h 707855f33b12a4508853dd76c8a18bc2bb06cdf6 
  src/QtMainWindow.cpp 171190097748cadffd2c7aba268fa0ec5f5a8067 
  src/lib/MarbleWidgetPopupMenu.cpp 4da64b0c84cbe66b59b51f59f3641c5f7879cb05 
  src/lib/RenderPlugin.h 63df0432bfc3ae4de851cabe92d839bf93c50662 
  src/lib/RenderPlugin.cpp 373205de5a4e1cd6016ffaf181bf55a1ecf368ba 
  src/marble_part.h 098d63793904761f997223eff166a6ccd2568389 
  src/marble_part.cpp 85269d80f1d164fa12a6b6f13f2e3b8ab0172ca1 

Diff: https://git.reviewboard.kde.org/r/106988/diff/


Testing
-------


Thanks,

Bernhard Beschow

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150627/36c9a03d/attachment.html>