<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/106988/">https://git.reviewboard.kde.org/r/106988/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Bernhard Beschow.</div>
<p style="color: grey;"><i>Updated Juni 27, 2015, 11:08 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">API change: remove RenderPlugin::action()
With this patch, the actions are created outside of the plugins which is more flexible.
In the KDE version, for instance, creation of KActions (rather than QActions) avoids 'marble(26988)/kdeui (kdelibs): Attempt to use QAction "" with KXMLGUIFactory!' warnings.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/QtMainWindow.h <span style="color: grey">(707855f33b12a4508853dd76c8a18bc2bb06cdf6)</span></li>
<li>src/QtMainWindow.cpp <span style="color: grey">(171190097748cadffd2c7aba268fa0ec5f5a8067)</span></li>
<li>src/lib/MarbleWidgetPopupMenu.cpp <span style="color: grey">(4da64b0c84cbe66b59b51f59f3641c5f7879cb05)</span></li>
<li>src/lib/RenderPlugin.h <span style="color: grey">(63df0432bfc3ae4de851cabe92d839bf93c50662)</span></li>
<li>src/lib/RenderPlugin.cpp <span style="color: grey">(373205de5a4e1cd6016ffaf181bf55a1ecf368ba)</span></li>
<li>src/marble_part.h <span style="color: grey">(098d63793904761f997223eff166a6ccd2568389)</span></li>
<li>src/marble_part.cpp <span style="color: grey">(85269d80f1d164fa12a6b6f13f2e3b8ab0172ca1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/106988/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>