[Marble-devel] Review Request 124064: Added macros and some bulk classes to be able to compile Marble with Qt for Android

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124064/#review81515
-----------------------------------------------------------


Looks fine in general. Most of the changes seem to occur because QWebView is deprecated and not available for Android. The same problem appears if for some reason a Qt version is used without support for QWebView, and a couple of people already asked us to support that. With that in mind I'd prefer not to use ANDROID checks at those places, but instead a switch like QT_NO_WEBKIT. In parallel someone (any volunteers?) can then start working on an alternative in Marble using QWebEngineView, see http://doc.qt.io/qt-5/qwebengineview.html This would be available in Android as well.


data/lang/CMakeLists.txt (line 14)
<https://git.reviewboard.kde.org/r/124064/#comment55878>

    does not make sense to me immediately. Can you explain this change?



src/apps/marble-mobile/CMakeLists.txt (line 28)
<https://git.reviewboard.kde.org/r/124064/#comment55879>

    same here, what is the intention? have some of the classes available later on when building a custom Android app and link to this as well?
    
    Otherwise if it's not needed on Android I'm fine with just not compiling it.



src/apps/marble-mobile/CMakeLists.txt (line 33)
<https://git.reviewboard.kde.org/r/124064/#comment55880>

    if (NOT ANDROID)
    ...
    endif()
    
    no need for the empty block.


- Dennis Nienhüser


On June 10, 2015, 7:35 p.m., Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124064/
> -----------------------------------------------------------
> 
> (Updated June 10, 2015, 7:35 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> It successfully compiles the source code for Android, but the final apk is bad (fix will be in a following patch, also there can be some problems with res/libs.xml and with the resources).
> 
> So the only purpose of this patch to have a source code which can be compiled for Android without compilation errors.
> 
> Some instructions to compile it:
> https://techbase.kde.org/Projects/Marble/AndroidCompiling
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt de4a9dc39b948385bdde574dcdb673a9938a186f 
>   data/lang/CMakeLists.txt e3c1fedb1d482a5573e3bb302fda6237b9893316 
>   src/apps/marble-mobile/CMakeLists.txt 82031bda6df3402dc69a09a5847f0a3ae2530cb7 
>   src/apps/marble-mobile/MobileMainWindow.cpp b2493f46135244daa131e197e3eb05bc7dc711b8 
>   src/lib/marble/MarbleLegendBrowser.h 7e80c389f9e8f0fe3876dc4fe23d917e70a078d9 
>   src/lib/marble/MarbleLegendBrowser.cpp f628b835534063aa459d67ddff10f33466ac59cd 
>   src/lib/marble/MarbleWebView.h d564111586a25148a8391767c4f210e83f153951 
>   src/lib/marble/MarbleWebView.cpp b67a7fbc95642b93455c2f0717ac4b31d181e7af 
>   src/lib/marble/PopupItem.cpp 8dd885c6efa4ed1c0981f835339b031720a24d01 
>   src/lib/marble/TinyWebBrowser.h 4e94eb5cf69710247d11358827ff7056f9253493 
>   src/lib/marble/TinyWebBrowser.cpp 52e88422c7bd3754a5235705b2de43ad77ed1437 
>   src/lib/marble/cloudsync/RouteItemDelegate.cpp 9670f1e3ccb643bab5400e84e01129b9cc6826a4 
>   src/lib/marble/routing/RoutingInputWidget.cpp 40c4aad9a93d3255a66fbfb98487401ee597321e 
>   src/plugins/render/CMakeLists.txt bdfc085f1feca6f94011a3ae32b84a76bbc1602e 
>   src/plugins/render/wikipedia/WikipediaItem.cpp c708d443caf80ac2246f4c886197c109b8942bf1 
> 
> Diff: https://git.reviewboard.kde.org/r/124064/diff/
> 
> 
> Testing
> -------
> 
> Obvious crash without loading anything, but this is supposed to happen:)
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150616/95f723a3/attachment.html>