<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124064/">https://git.reviewboard.kde.org/r/124064/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks fine in general. Most of the changes seem to occur because QWebView is deprecated and not available for Android. The same problem appears if for some reason a Qt version is used without support for QWebView, and a couple of people already asked us to support that. With that in mind I'd prefer not to use ANDROID checks at those places, but instead a switch like QT_NO_WEBKIT. In parallel someone (any volunteers?) can then start working on an alternative in Marble using QWebEngineView, see http://doc.qt.io/qt-5/qwebengineview.html This would be available in Android as well.</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124064/diff/1/?file=379488#file379488line15" style="color: black; font-weight: bold; text-decoration: underline;">data/lang/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">14</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">add_library</span><span class="p">(</span> <span class="o">${</span><span class="nv">TARGET</span><span class="o">}</span> <span class="o">${</span><span class="nv">${TARGET</span><span class="o">}</span><span class="s">_SRC}</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">does not make sense to me immediately. Can you explain this change?</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124064/diff/1/?file=379489#file379489line28" style="color: black; font-weight: bold; text-decoration: underline;">src/apps/marble-mobile/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">28</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">add_library</span><span class="p">(</span> <span class="s">marble-mobile</span> <span class="o">${</span><span class="nv">marblemobile_SRCS</span><span class="o">}</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">same here, what is the intention? have some of the classes available later on when building a custom Android app and link to this as well?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Otherwise if it's not needed on Android I'm fine with just not compiling it.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124064/diff/1/?file=379489#file379489line33" style="color: black; font-weight: bold; text-decoration: underline;">src/apps/marble-mobile/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">33</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">if</span> <span class="p">(</span><span class="s">ANDROID</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if (NOT ANDROID)
...
endif()</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">no need for the empty block.</p></pre>
</div>
</div>
<br />
<p>- Dennis Nienhüser</p>
<br />
<p>On June 10th, 2015, 7:35 p.m. UTC, Gábor Péterffy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Gábor Péterffy.</div>
<p style="color: grey;"><i>Updated June 10, 2015, 7:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It successfully compiles the source code for Android, but the final apk is bad (fix will be in a following patch, also there can be some problems with res/libs.xml and with the resources).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So the only purpose of this patch to have a source code which can be compiled for Android without compilation errors.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Some instructions to compile it:
https://techbase.kde.org/Projects/Marble/AndroidCompiling</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Obvious crash without loading anything, but this is supposed to happen:)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(de4a9dc39b948385bdde574dcdb673a9938a186f)</span></li>
<li>data/lang/CMakeLists.txt <span style="color: grey">(e3c1fedb1d482a5573e3bb302fda6237b9893316)</span></li>
<li>src/apps/marble-mobile/CMakeLists.txt <span style="color: grey">(82031bda6df3402dc69a09a5847f0a3ae2530cb7)</span></li>
<li>src/apps/marble-mobile/MobileMainWindow.cpp <span style="color: grey">(b2493f46135244daa131e197e3eb05bc7dc711b8)</span></li>
<li>src/lib/marble/MarbleLegendBrowser.h <span style="color: grey">(7e80c389f9e8f0fe3876dc4fe23d917e70a078d9)</span></li>
<li>src/lib/marble/MarbleLegendBrowser.cpp <span style="color: grey">(f628b835534063aa459d67ddff10f33466ac59cd)</span></li>
<li>src/lib/marble/MarbleWebView.h <span style="color: grey">(d564111586a25148a8391767c4f210e83f153951)</span></li>
<li>src/lib/marble/MarbleWebView.cpp <span style="color: grey">(b67a7fbc95642b93455c2f0717ac4b31d181e7af)</span></li>
<li>src/lib/marble/PopupItem.cpp <span style="color: grey">(8dd885c6efa4ed1c0981f835339b031720a24d01)</span></li>
<li>src/lib/marble/TinyWebBrowser.h <span style="color: grey">(4e94eb5cf69710247d11358827ff7056f9253493)</span></li>
<li>src/lib/marble/TinyWebBrowser.cpp <span style="color: grey">(52e88422c7bd3754a5235705b2de43ad77ed1437)</span></li>
<li>src/lib/marble/cloudsync/RouteItemDelegate.cpp <span style="color: grey">(9670f1e3ccb643bab5400e84e01129b9cc6826a4)</span></li>
<li>src/lib/marble/routing/RoutingInputWidget.cpp <span style="color: grey">(40c4aad9a93d3255a66fbfb98487401ee597321e)</span></li>
<li>src/plugins/render/CMakeLists.txt <span style="color: grey">(bdfc085f1feca6f94011a3ae32b84a76bbc1602e)</span></li>
<li>src/plugins/render/wikipedia/WikipediaItem.cpp <span style="color: grey">(c708d443caf80ac2246f4c886197c109b8942bf1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124064/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>