[Marble-devel] Review Request 124457: [MarbleMaps] Basic plugin install mechanism for Android.

[Dennis Nienhüser]

Hi Alexander,

the dependency is indirectly connected to Android: LocalOsmSearchPlugin 
requires it and dynamic library loading does not work on Android, so 
something must load it directly. Another approach than linking the 
marble_maps application against QtSql would be to add QtSql as a 
dependency to the Marble library. Both the marble_maps application as 
well as the Marble library only exist in Android builds, so there is no 
need to split the patch up.

Regards,
Dennis

Am 24.07.2015 22:03, schrieb Alexander Potashev:
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124457/ [2]
> 
> Is dependency on Qt5Sql connected to the Android stuff in this patch?
> May be it would be better to split this into 2 patches so that Qt5Sql
> is added in a separate one?
> 
> - Alexander Potashev
> 
> On July 24th, 2015, 8 p.m. UTC, Mihail Ivchenko wrote:
> 
> Review request for Marble and Gábor Péterffy.
> By Mihail Ivchenko.
> 
> _Updated July 24, 2015, 8 p.m._
>  REPOSITORY: marble
> 
> DESCRIPTION
> 
> Basic plugin install mechanism for Android. Also link Qt5Sql library
> (LocalOsmSearchPlugin requires it).
> 
> Based on work of Gábor Péterffy [1]
> 
> TESTING
> 
> Works well on Nexus 5 & Nexus 9 (both are Android 5.1.1)
> 
> DIFFS
> 
>  	* CMakeLists.txt (7c83158)
>  	* src/CMakeLists.txt (9dd39ff)
>  	* src/apps/marble_maps/CMakeLists.txt (3260a69)
>  	* src/lib/marble/CMakeLists.txt (78f5395)
>  	* src/lib/marble/MarbleDirs.cpp (8dd3fe0)
>  	* src/lib/marble/PluginManager.h (a4ae142)
>  	* src/lib/marble/PluginManager.cpp (b76739c)
>  	* src/plugins/CMakeLists.txt (011b77a)
> 
> View Diff [3]
> 
> 
> 
> Links:
> ------
> [1] https://git.reviewboard.kde.org/r/124337/
> [2] https://git.reviewboard.kde.org/r/124457/
> [3] https://git.reviewboard.kde.org/r/124457/diff/
> 
> _______________________________________________
> Marble-devel mailing list
> Marble-devel at kde.org
> https://mail.kde.org/mailman/listinfo/marble-devel