[Marble-devel] Review Request 124457: [MarbleMaps] Basic plugin install mechanism for Android.

[Alexander Potashev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124457/#review82919
-----------------------------------------------------------


Is dependency on Qt5Sql connected to the Android stuff in this patch? May be it would be better to split this into 2 patches so that Qt5Sql is added in a separate one?

- Alexander Potashev


On July 24, 2015, 8 p.m., Mihail Ivchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124457/
> -----------------------------------------------------------
> 
> (Updated July 24, 2015, 8 p.m.)
> 
> 
> Review request for Marble and Gábor Péterffy.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Basic plugin install mechanism for Android. Also link Qt5Sql library (LocalOsmSearchPlugin requires it).
> 
> Based on [work of Gábor Péterffy](https://git.reviewboard.kde.org/r/124337/)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7c83158 
>   src/CMakeLists.txt 9dd39ff 
>   src/apps/marble_maps/CMakeLists.txt 3260a69 
>   src/lib/marble/CMakeLists.txt 78f5395 
>   src/lib/marble/MarbleDirs.cpp 8dd3fe0 
>   src/lib/marble/PluginManager.h a4ae142 
>   src/lib/marble/PluginManager.cpp b76739c 
>   src/plugins/CMakeLists.txt 011b77a 
> 
> Diff: https://git.reviewboard.kde.org/r/124457/diff/
> 
> 
> Testing
> -------
> 
> Works well on Nexus 5 & Nexus 9 (both are Android 5.1.1)
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150724/79a93e10/attachment.html>