[Marble-devel] Review Request 124396: Adding a menu for Marble Maps

[Dennis Nienhüser]

> On July 20, 2015, 11:19 a.m., Mihail Ivchenko wrote:
> > Am I right that you are implementing your own "Menu bar"? Isn't it better to use standard [MenuBar from QtQuick.Controls](http://doc.qt.io/qt-5/qml-qtquick-controls-menubar.html)?  Also, you can use [ApplicationWindow](http://doc.qt.io/qt-5/qml-qtquick-controls-applicationwindow.html) which make it easier to place menubar\toolbar\statusbar. But both of them will require switching to [QQmlApplicationEngine](http://doc.qt.io/qt-5/qqmlapplicationengine.html). (It doesn't looks so hard, but I haven't much experience).
> > 
> > I have tried to modify your existing code and it looks so: (only zoom and menu, without search): [main.cpp](https://paste.kde.org/pjuc4eb5b/agbagm) and [MainScreen.qml](https://paste.kde.org/pnjudhwl3/bb5jyb). Maybe it doesn't some functionallity right now because of switching to QQmlApplicationEngine, I'm not sure.
> > 
> > Also, with using standard controls you are able to choose android themes (Holo is well supported and Material is _very partially_ supported in Qt5.4). There are some screenshots from my demo:
> > * [Holo Dark](http://s8.postimg.org/yfynzudg5/Holo_Dark.png)
> > * [Holo Light](http://s8.postimg.org/64d42stjp/Holo_Light.png)
> > * [Material Dark](http://s8.postimg.org/mtejypq51/Material_Dark.png)
> > * [Material Light](http://s8.postimg.org/bd850obyt/Material_Light.png)
> > 
> > P.S. Dennis and Torsten, what do you think about that?
> > P.P.S. Also, I personnaly prefer Material Icons if it's possible, so it will look more like standard Material Design.
> 
> Mihail Ivchenko wrote:
>     Forget to mention that my example contains very simple example. I just copy-pasted it from doc.qt.io, so, of course, "File", "Edit" options should be changed to preferable one. Also, clicking on button doesn't do anything, it's just a sample.
>     Also, there is a [short article](https://blog.qt.io/blog/2014/12/03/native-android-style-in-qt-5-4/) about native android style in Qt and themes support.
> 
> Torsten Rahn wrote:
>     Yes those suggestions are all very good. :)

This makes a lot of sense and will result in a much more consistent looking application (and will save a lot of time we can then spend on integrating more features). Let's go with that approach!


- Dennis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124396/#review82693
-----------------------------------------------------------


On July 19, 2015, 10:08 p.m., Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124396/
> -----------------------------------------------------------
> 
> (Updated July 19, 2015, 10:08 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This adds a menu to Marble Maps. It uses a gridview to present the model. This patch also autohides the search bar. It appears when the user selects it from the menu.
> 
> 
> Diffs
> -----
> 
>   data/android/pixmaps/searchMenuIcon.png PRE-CREATION 
>   src/apps/marble_maps/MainScreen.qml PRE-CREATION 
>   src/apps/marble_maps/MarbleMaps.qrc PRE-CREATION 
>   src/apps/marble_maps/MenuItem.qml PRE-CREATION 
>   src/apps/marble_maps/MenuModel.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124396/diff/
> 
> 
> Testing
> -------
> 
> Works fine on my device.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/a20c33dc-405f-43cc-8fb0-00119283edb6__Screenshot_2015-07-19-22-29-14.png
> searchMenuIcon.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/19584e97-4ab3-47f4-8496-f0096d16e9b2__searchMenuIcon.png
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150721/edb46d34/attachment-0001.html>