<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124396/">https://git.reviewboard.kde.org/r/124396/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 20th, 2015, 11:19 a.m. UTC, <b>Mihail Ivchenko</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Am I right that you are implementing your own "Menu bar"? Isn't it better to use standard <a href="http://doc.qt.io/qt-5/qml-qtquick-controls-menubar.html" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">MenuBar from QtQuick.Controls</a>? Also, you can use <a href="http://doc.qt.io/qt-5/qml-qtquick-controls-applicationwindow.html" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">ApplicationWindow</a> which make it easier to place menubar\toolbar\statusbar. But both of them will require switching to <a href="http://doc.qt.io/qt-5/qqmlapplicationengine.html" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">QQmlApplicationEngine</a>. (It doesn't looks so hard, but I haven't much experience).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have tried to modify your existing code and it looks so: (only zoom and menu, without search): <a href="https://paste.kde.org/pjuc4eb5b/agbagm" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">main.cpp</a> and <a href="https://paste.kde.org/pnjudhwl3/bb5jyb" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">MainScreen.qml</a>. Maybe it doesn't some functionallity right now because of switching to QQmlApplicationEngine, I'm not sure.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, with using standard controls you are able to choose android themes (Holo is well supported and Material is <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">very partially</em> supported in Qt5.4). There are some screenshots from my demo:
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> <a href="http://s8.postimg.org/yfynzudg5/Holo_Dark.png" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Holo Dark</a>
</em> <a href="http://s8.postimg.org/64d42stjp/Holo_Light.png" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Holo Light</a>
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> <a href="http://s8.postimg.org/mtejypq51/Material_Dark.png" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Material Dark</a>
</em> <a href="http://s8.postimg.org/bd850obyt/Material_Light.png" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Material Light</a></p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">P.S. Dennis and Torsten, what do you think about that?
P.P.S. Also, I personnaly prefer Material Icons if it's possible, so it will look more like standard Material Design.</p></pre>
</blockquote>
<p>On July 20th, 2015, 11:27 a.m. UTC, <b>Mihail Ivchenko</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Forget to mention that my example contains very simple example. I just copy-pasted it from doc.qt.io, so, of course, "File", "Edit" options should be changed to preferable one. Also, clicking on button doesn't do anything, it's just a sample.
Also, there is a <a href="https://blog.qt.io/blog/2014/12/03/native-android-style-in-qt-5-4/" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">short article</a> about native android style in Qt and themes support.</p></pre>
</blockquote>
<p>On July 20th, 2015, 12:24 p.m. UTC, <b>Torsten Rahn</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes those suggestions are all very good. :)</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This makes a lot of sense and will result in a much more consistent looking application (and will save a lot of time we can then spend on integrating more features). Let's go with that approach!</p></pre>
<br />
<p>- Dennis</p>
<br />
<p>On July 19th, 2015, 10:08 p.m. UTC, Gábor Péterffy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Gábor Péterffy.</div>
<p style="color: grey;"><i>Updated July 19, 2015, 10:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This adds a menu to Marble Maps. It uses a gridview to present the model. This patch also autohides the search bar. It appears when the user selects it from the menu.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works fine on my device.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/android/pixmaps/searchMenuIcon.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble_maps/MainScreen.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble_maps/MarbleMaps.qrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble_maps/MenuItem.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble_maps/MenuModel.qml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124396/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/a20c33dc-405f-43cc-8fb0-00119283edb6__Screenshot_2015-07-19-22-29-14.png">Screenshot.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/19584e97-4ab3-47f4-8496-f0096d16e9b2__searchMenuIcon.png">searchMenuIcon.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>