[Marble-devel] Review Request 124396: Adding a menu for Marble Maps

[Gábor Péterffy]

> On júl. 19, 2015, 5:43 du, Torsten Rahn wrote:
> > src/apps/marble_maps/MenuItem.qml, line 3
> > <https://git.reviewboard.kde.org/r/124396/diff/1/?file=386006#file386006line3>
> >
> >     As explained before the hierarchy is messed up.
> >     
> >     Right now your MenuItem _is_ a rectangle which _is_ the background. Also the root element should always have the id "root".
> >     
> >     So the menuItem should look like this:
> >     
> >     Item {
> >         id: root
> >         
> >         Rectangle {
> >             id: background
> >             color: "#1a1a1a"
> >             anchors.fill: parent
> >         }
> >         GridView {
> >             id: gridView 
> >             anchors.fill: parent
> >         }
> >     }
> >     
> >     Please fix.

Thank you, I haven't noticed your previous comment. I am going to fix this.


- Gábor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124396/#review82649
-----------------------------------------------------------


On júl. 20, 2015, 12:08 de, Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124396/
> -----------------------------------------------------------
> 
> (Updated júl. 20, 2015, 12:08 de)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This adds a menu to Marble Maps. It uses a gridview to present the model. This patch also autohides the search bar. It appears when the user selects it from the menu.
> 
> 
> Diffs
> -----
> 
>   data/android/pixmaps/searchMenuIcon.png PRE-CREATION 
>   src/apps/marble_maps/MainScreen.qml PRE-CREATION 
>   src/apps/marble_maps/MarbleMaps.qrc PRE-CREATION 
>   src/apps/marble_maps/MenuItem.qml PRE-CREATION 
>   src/apps/marble_maps/MenuModel.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124396/diff/
> 
> 
> Testing
> -------
> 
> Works fine on my device.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/a20c33dc-405f-43cc-8fb0-00119283edb6__Screenshot_2015-07-19-22-29-14.png
> searchMenuIcon.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/19584e97-4ab3-47f4-8496-f0096d16e9b2__searchMenuIcon.png
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150719/a5162e30/attachment.html>