[Marble-devel] Review Request 124396: Adding a menu for Marble Maps
Dennis Nienhüser
dennis at nienhueser.de
Sun Jul 19 17:26:42 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124396/#review82659
-----------------------------------------------------------
Can you attach searchMenuIcon.png please? And maybe also a screenshot if you have one at hand... thanks :-)
- Dennis Nienhüser
On July 19, 2015, 3:35 p.m., Gábor Péterffy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124396/
> -----------------------------------------------------------
>
> (Updated July 19, 2015, 3:35 p.m.)
>
>
> Review request for Marble.
>
>
> Repository: marble
>
>
> Description
> -------
>
> This adds a menu to Marble Maps. It uses a gridview to present the model. This patch also autohides the search bar. It appears when the user selects it from the menu.
>
>
> Diffs
> -----
>
> data/android/pixmaps/searchMenuIcon.png PRE-CREATION
> src/apps/marble_maps/MainScreen.qml PRE-CREATION
> src/apps/marble_maps/MarbleMaps.qrc PRE-CREATION
> src/apps/marble_maps/MenuItem.qml PRE-CREATION
> src/apps/marble_maps/MenuModel.qml PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/124396/diff/
>
>
> Testing
> -------
>
> Works fine on my device.
>
>
> Thanks,
>
> Gábor Péterffy
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150719/ce677f19/attachment.html>
More information about the Marble-devel
mailing list