[Marble-devel] Review Request 124096: gsoc: osm writer classes

[Marius Stanciu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124096/
-----------------------------------------------------------

(Updated July 15, 2015, 2:05 p.m.)


Review request for Marble.


Changes
-------

fixed issues


Repository: marble


Description
-------

Classes with static functions that make writing typical osm tags convenient ( <node>, <way>, <relation>, <osm> )


Diffs (updated)
-----

  src/lib/marble/geodata/writer/GeoWriter.h 1a1a91e 
  src/lib/marble/geodata/writer/GeoWriter.cpp 05762f5 
  src/plugins/runner/osm/CMakeLists.txt 4a341e7 
  src/plugins/runner/osm/OsmObjectManager.h PRE-CREATION 
  src/plugins/runner/osm/OsmObjectManager.cpp PRE-CREATION 
  src/plugins/runner/osm/writers/OsmObjectAttributeWriter.h PRE-CREATION 
  src/plugins/runner/osm/writers/OsmObjectAttributeWriter.cpp PRE-CREATION 
  src/plugins/runner/osm/writers/OsmTagTagWriter.h PRE-CREATION 
  src/plugins/runner/osm/writers/OsmTagTagWriter.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124096/diff/


Testing
-------

No testing was done yet as these are just static functions, will taste in later patches.
Compiles fine


Thanks,

Marius Stanciu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150715/6552c58c/attachment.html>