[Marble-devel] Review Request 124096: gsoc: osm writer classes

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124096/#review82407
-----------------------------------------------------------

Ship it!



src/plugins/runner/osm/writers/OsmRelationTagWriter.cpp (line 46)
<https://git.reviewboard.kde.org/r/124096/#comment56790>

    overwrites the previously declared ring variable. That's fine technically, but I'd prefer renaming it innerRing to avoid confusion.



src/plugins/runner/osm/writers/OsmWayTagWriter.cpp (line 23)
<https://git.reviewboard.kde.org/r/124096/#comment56791>

    not needed


- Dennis Nienhüser


On July 10, 2015, 12:54 p.m., Marius Stanciu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124096/
> -----------------------------------------------------------
> 
> (Updated July 10, 2015, 12:54 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Classes with static functions that make writing typical osm tags convenient ( <node>, <way>, <relation>, <osm> )
> 
> 
> Diffs
> -----
> 
>   src/plugins/runner/osm/writers/OsmNodeTagWriter.h PRE-CREATION 
>   src/plugins/runner/osm/writers/OsmNodeTagWriter.cpp PRE-CREATION 
>   src/plugins/runner/osm/writers/OsmRelationTagWriter.h PRE-CREATION 
>   src/plugins/runner/osm/writers/OsmRelationTagWriter.cpp PRE-CREATION 
>   src/plugins/runner/osm/writers/OsmTagWriter.h PRE-CREATION 
>   src/plugins/runner/osm/writers/OsmTagWriter.cpp PRE-CREATION 
>   src/plugins/runner/osm/writers/OsmWayTagWriter.h PRE-CREATION 
>   src/plugins/runner/osm/writers/OsmWayTagWriter.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124096/diff/
> 
> 
> Testing
> -------
> 
> No testing was done yet as these are just static functions, will taste in later patches.
> Compiles fine
> 
> 
> Thanks,
> 
> Marius Stanciu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150712/a528f2b1/attachment.html>