[Marble-devel] Review Request 124232: gsoc: Easy, safe accessor for OsmPlacemarkData objects

Marius Stanciu stanciumarius94 at gmail.com
Wed Jul 15 14:03:43 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124232/
-----------------------------------------------------------

(Updated July 15, 2015, 2:03 p.m.)


Review request for Marble.


Changes
-------

made some strings static  const


Repository: marble


Description
-------

Adding this to the GeoDataPlacemark might not be really the best idea, but this makes accessing the osmdata object within a placemark's extended data really easy, and very similar to the other accessors.


Diffs (updated)
-----

  src/lib/marble/geodata/data/GeoDataData.h 491cb61 
  src/lib/marble/geodata/data/GeoDataData.cpp e565c2c 
  src/lib/marble/geodata/data/GeoDataPlacemark.h 726befb 
  src/lib/marble/geodata/data/GeoDataPlacemark.cpp 7af4f9a 

Diff: https://git.reviewboard.kde.org/r/124232/diff/


Testing
-------


Thanks,

Marius Stanciu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150715/2df632e3/attachment.html>


More information about the Marble-devel mailing list