[Marble-devel] Review Request 124232: gsoc: Easy, safe accessor for OsmPlacemarkData objects

Dennis Nienhüser dennis at nienhueser.de
Sun Jul 12 17:38:40 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124232/#review82401
-----------------------------------------------------------

Ship it!


Ship It!

- Dennis Nienhüser


On July 10, 2015, 12:50 p.m., Marius Stanciu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124232/
> -----------------------------------------------------------
> 
> (Updated July 10, 2015, 12:50 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Adding this to the GeoDataPlacemark might not be really the best idea, but this makes accessing the osmdata object within a placemark's extended data really easy, and very similar to the other accessors.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/data/GeoDataData.h 491cb61 
>   src/lib/marble/geodata/data/GeoDataData.cpp e565c2c 
>   src/lib/marble/geodata/data/GeoDataPlacemark.h 726befb 
>   src/lib/marble/geodata/data/GeoDataPlacemark.cpp 7af4f9a 
> 
> Diff: https://git.reviewboard.kde.org/r/124232/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marius Stanciu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150712/793237d2/attachment.html>


More information about the Marble-devel mailing list