[Marble-devel] Review Request 124346: Working zoom for Marble Maps

[Gábor Péterffy]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124346/#review82524
-----------------------------------------------------------


By Dennis:

"Can you give the following layouts a try?

1) Separating search bar and MarbleItem

Rectangle {  
  SearchBar { 
    anchors: top, left and right to parent's respective anchors
  }
  MarbleItem {
    anchors: top to SearchBar, left, right and bottom to parent's respective anchors
    PinchArea {anchors.fill: parent}
  }
}

2) SearchBar on top of MarbleItem

Rectangle {  
  MarbleItem {
    anchors.fill: parent
    PinchArea {anchors.fill: parent}
    SearchBar { 
      anchors: top, left and right to parent's respective anchors
      height: some sane height}
  }
}

The second example is pretty similar to what I understand you were trying to achieve. The interesting part is the order of PinchArea and SearchBar, i.e. create PinchArea first. This might fix the problem you describe."


I don't like the first approach because I think they should be in parent child relation. By the way the second version is working "partially". The search bar works, the zooming works but the panning not. In my version everything works.

- Gábor Péterffy


On júl. 14, 2015, 1:29 du, Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124346/
> -----------------------------------------------------------
> 
> (Updated júl. 14, 2015, 1:29 du)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> I have added a pinch area to Marble Maps and I have added the needed slots to MarbleQuickItem.
> 
> 
> Diffs
> -----
> 
>   src/apps/marble_maps/MainScreen.qml PRE-CREATION 
>   src/lib/marble/MarbleQuickItem.h 41e20bb69bbeb9c1d662cd943ecb13674fd04498 
>   src/lib/marble/MarbleQuickItem.cpp 94a0a1a498d4be29778f055d6c05bb532f12ee44 
> 
> Diff: https://git.reviewboard.kde.org/r/124346/diff/
> 
> 
> Testing
> -------
> 
> Works fine ony my phone. (Interesting fact: If I put the PinchArea inside MarbleItem it not works if I don't use anchors.fill: parent, but in this case, the search field will not work)
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150715/f7b5140a/attachment.html>