<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124346/">https://git.reviewboard.kde.org/r/124346/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">By Dennis:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">"Can you give the following layouts a try?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1) Separating search bar and MarbleItem</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Rectangle {<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
SearchBar {
anchors: top, left and right to parent's respective anchors
}
MarbleItem {
anchors: top to SearchBar, left, right and bottom to parent's respective anchors
PinchArea {anchors.fill: parent}
}
}</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">2) SearchBar on top of MarbleItem</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Rectangle {<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
MarbleItem {
anchors.fill: parent
PinchArea {anchors.fill: parent}
SearchBar {
anchors: top, left and right to parent's respective anchors
height: some sane height}
}
}</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The second example is pretty similar to what I understand you were trying to achieve. The interesting part is the order of PinchArea and SearchBar, i.e. create PinchArea first. This might fix the problem you describe."</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't like the first approach because I think they should be in parent child relation. By the way the second version is working "partially". The search bar works, the zooming works but the panning not. In my version everything works.</p></pre>
<br />
<p>- Gábor Péterffy</p>
<br />
<p>On július 14th, 2015, 1:29 du CEST, Gábor Péterffy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Gábor Péterffy.</div>
<p style="color: grey;"><i>Updated júl. 14, 2015, 1:29 du</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have added a pinch area to Marble Maps and I have added the needed slots to MarbleQuickItem.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works fine ony my phone. (Interesting fact: If I put the PinchArea inside MarbleItem it not works if I don't use anchors.fill: parent, but in this case, the search field will not work)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/apps/marble_maps/MainScreen.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MarbleQuickItem.h <span style="color: grey">(41e20bb69bbeb9c1d662cd943ecb13674fd04498)</span></li>
<li>src/lib/marble/MarbleQuickItem.cpp <span style="color: grey">(94a0a1a498d4be29778f055d6c05bb532f12ee44)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124346/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>