[Marble-devel] Review Request 124337: Basic plugin install mechanism for Android

[Gábor Péterffy]

> On júl. 13, 2015, 7:41 du, Dennis Nienhüser wrote:
> > src/CMakeLists.txt, line 50
> > <https://git.reviewboard.kde.org/r/124337/diff/1/?file=385084#file385084line50>
> >
> >     I don't think that option makes sense really. If the libs are not built, nothing else can be build really. Do you have a use-case in mind for this?

Because the two step build for Android I thinked it is enough to build and check only once, but you are right one more check on the libs good.


- Gábor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124337/#review82460
-----------------------------------------------------------


On júl. 14, 2015, 1:39 de, Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124337/
> -----------------------------------------------------------
> 
> (Updated júl. 14, 2015, 1:39 de)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> With this patch plugins what are placed into assets/plugins automatically will be copied into the app's local data directory, and after that they can be loaded by Marble Maps.
> An other modification that runner plugins can be compiled for Android, so they now can be included. For the how, please check the techbase install guide.
> 
> 
> Diffs
> -----
> 
>   src/plugins/CMakeLists.txt 011b77ae520875619f20379b32b731af0028a90d 
>   src/lib/marble/PluginManager.cpp f323b4ffa0a92b6ab5de3a73a13ce16bf609380b 
>   src/lib/marble/PluginManager.h a4ae1421ff1ed4036472b4bbcb216bb5d4f205a5 
>   src/lib/marble/MarbleDirs.cpp 8dd3fe07cd12672df21faa23369c887e566b176d 
>   src/lib/marble/CMakeLists.txt 8b36d0843f585c09c62bf044d0cfb0651a13d4b0 
>   src/apps/marble_maps/CMakeLists.txt PRE-CREATION 
>   src/CMakeLists.txt 78b83a39ac26b17b82b072d6309bb30d88bf6534 
>   CMakeLists.txt de4a9dc39b948385bdde574dcdb673a9938a186f 
> 
> Diff: https://git.reviewboard.kde.org/r/124337/diff/
> 
> 
> Testing
> -------
> 
> It works fine on my phone.
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150713/279f0bf6/attachment.html>