<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124337/">https://git.reviewboard.kde.org/r/124337/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On július 13th, 2015, 7:41 du CEST, <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124337/diff/1/?file=385084#file385084line50" style="color: black; font-weight: bold; text-decoration: underline;">src/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">50</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">option</span><span class="p">(</span><span class="s">BUILD_MARBLE_LIBS</span> <span class="s2">"Build Marble libs"</span> <span class="s">ON</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't think that option makes sense really. If the libs are not built, nothing else can be build really. Do you have a use-case in mind for this?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Because the two step build for Android I thinked it is enough to build and check only once, but you are right one more check on the libs good.</p></pre>
<br />
<p>- Gábor</p>
<br />
<p>On július 14th, 2015, 1:39 de CEST, Gábor Péterffy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Gábor Péterffy.</div>
<p style="color: grey;"><i>Updated júl. 14, 2015, 1:39 de</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With this patch plugins what are placed into assets/plugins automatically will be copied into the app's local data directory, and after that they can be loaded by Marble Maps.
An other modification that runner plugins can be compiled for Android, so they now can be included. For the how, please check the techbase install guide.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It works fine on my phone.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/CMakeLists.txt <span style="color: grey">(011b77ae520875619f20379b32b731af0028a90d)</span></li>
<li>src/lib/marble/PluginManager.cpp <span style="color: grey">(f323b4ffa0a92b6ab5de3a73a13ce16bf609380b)</span></li>
<li>src/lib/marble/PluginManager.h <span style="color: grey">(a4ae1421ff1ed4036472b4bbcb216bb5d4f205a5)</span></li>
<li>src/lib/marble/MarbleDirs.cpp <span style="color: grey">(8dd3fe07cd12672df21faa23369c887e566b176d)</span></li>
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(8b36d0843f585c09c62bf044d0cfb0651a13d4b0)</span></li>
<li>src/apps/marble_maps/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(78b83a39ac26b17b82b072d6309bb30d88bf6534)</span></li>
<li>CMakeLists.txt <span style="color: grey">(de4a9dc39b948385bdde574dcdb673a9938a186f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124337/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>