[Marble-devel] Review Request 121934: Replacing EARTH_RADIUS in projection classes

[Illya Kovalevskyy]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121934/
-----------------------------------------------------------

(Updated Jan. 10, 2015, 8:07 p.m.)


Status
------

This change has been marked as submitted.


Review request for Marble, Bernhard Beschow, Dennis Nienhüser, and Torsten Rahn.


Repository: marble


Description
-------

This patch does get rid of `EARTH_RADIUS` from projection classes, by storing current planet radius in ViewportParams.

Related GCI-2014 task: http://www.google-melange.com/gci/task/view/google/gci2014/5895892615823360


Diffs
-----

  src/lib/marble/MarbleMap.h 260d46b 
  src/lib/marble/MarbleMap.cpp 13becfc 
  src/lib/marble/MarbleModel.h f13491e 
  src/lib/marble/MarbleModel.cpp 04605c6 
  src/lib/marble/ViewportParams.h 09aeecb 
  src/lib/marble/ViewportParams.cpp bca8ea9 
  src/lib/marble/projections/SphericalProjection.cpp c11300b 
  src/lib/marble/projections/VerticalPerspectiveProjection.cpp 806e028 

Diff: https://git.reviewboard.kde.org/r/121934/diff/


Testing
-------

Visual testing, see screenshots.


File Attachments
----------------

Current state
  https://git.reviewboard.kde.org/media/uploaded/files/2015/01/10/c85bade0-be72-4eda-b7c5-15c47a8f994d__Screen_Shot_2015-01-10_at_10.01.04_PM.png
With patch applied
  https://git.reviewboard.kde.org/media/uploaded/files/2015/01/10/dd24a0cd-de87-47a0-bf34-258ffe94f8ca__Screen_Shot_2015-01-10_at_9.47.41_PM.png


Thanks,

Illya Kovalevskyy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150110/6028420e/attachment.html>