<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121934/">https://git.reviewboard.kde.org/r/121934/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble, Bernhard Beschow, Dennis Nienhüser, and Torsten Rahn.</div>
<div>By Illya Kovalevskyy.</div>
<p style="color: grey;"><i>Updated Jan. 10, 2015, 8:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch does get rid of <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">EARTH_RADIUS</code> from projection classes, by storing current planet radius in ViewportParams.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Related GCI-2014 task: http://www.google-melange.com/gci/task/view/google/gci2014/5895892615823360</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Visual testing, see screenshots.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/MarbleMap.h <span style="color: grey">(260d46b)</span></li>
<li>src/lib/marble/MarbleMap.cpp <span style="color: grey">(13becfc)</span></li>
<li>src/lib/marble/MarbleModel.h <span style="color: grey">(f13491e)</span></li>
<li>src/lib/marble/MarbleModel.cpp <span style="color: grey">(04605c6)</span></li>
<li>src/lib/marble/ViewportParams.h <span style="color: grey">(09aeecb)</span></li>
<li>src/lib/marble/ViewportParams.cpp <span style="color: grey">(bca8ea9)</span></li>
<li>src/lib/marble/projections/SphericalProjection.cpp <span style="color: grey">(c11300b)</span></li>
<li>src/lib/marble/projections/VerticalPerspectiveProjection.cpp <span style="color: grey">(806e028)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121934/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/01/10/c85bade0-be72-4eda-b7c5-15c47a8f994d__Screen_Shot_2015-01-10_at_10.01.04_PM.png">Current state</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/01/10/dd24a0cd-de87-47a0-bf34-258ffe94f8ca__Screen_Shot_2015-01-10_at_9.47.41_PM.png">With patch applied</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>