[Marble-devel] Review Request 121820: Adjust the Licensing/Credits for the About Dialog

[bunu bunu]

> On Jan. 5, 2015, 1:47 p.m., Torsten Rahn wrote:
> > src/apps/marble-touch/AboutMarblePage.qml, line 123
> > <https://git.reviewboard.kde.org/r/121820/diff/1/?file=338037#file338037line123>
> >
> >     Actually the "real" place for this is inside src/lib/marble/MarbleAboutDialog.cpp . Can you please add it there instead? And can you please test it and create a screenshot of your patch working? :)

I believe you mean it has to be there as well.


- bunu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121820/#review73161
-----------------------------------------------------------


On Jan. 3, 2015, 11:30 p.m., bunu bunu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121820/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2015, 11:30 p.m.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Look at: http://www.google-melange.com/gci/task/view/google/gci2014/5906685600202752
> 
> 
> Diffs
> -----
> 
>   data/credits_authors.html 586211d 
>   data/credits_data.html f027f46 
>   src/apps/marble-touch/AboutMarblePage.qml 86c3588 
> 
> Diff: https://git.reviewboard.kde.org/r/121820/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> bunu bunu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150106/8a38e670/attachment.html>