[Marble-devel] Review Request 121820: Adjust the Licensing/Credits for the About Dialog
Torsten Rahn
tackat at kde.org
Mon Jan 5 13:47:08 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121820/#review73161
-----------------------------------------------------------
src/apps/marble-touch/AboutMarblePage.qml
<https://git.reviewboard.kde.org/r/121820/#comment50866>
Actually the "real" place for this is inside src/lib/marble/MarbleAboutDialog.cpp . Can you please add it there instead? And can you please test it and create a screenshot of your patch working? :)
- Torsten Rahn
On Jan. 3, 2015, 11:30 nachm., bunu bunu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121820/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2015, 11:30 nachm.)
>
>
> Review request for Marble and Torsten Rahn.
>
>
> Repository: marble
>
>
> Description
> -------
>
> Look at: http://www.google-melange.com/gci/task/view/google/gci2014/5906685600202752
>
>
> Diffs
> -----
>
> data/credits_authors.html 586211d
> data/credits_data.html f027f46
> src/apps/marble-touch/AboutMarblePage.qml 86c3588
>
> Diff: https://git.reviewboard.kde.org/r/121820/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> bunu bunu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150105/9ddb2c80/attachment.html>
More information about the Marble-devel
mailing list