[Marble-devel] Review Request 124822: gsoc: Introduces custom relation editing to placemarks within the AnnotatePlugin

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124822/#review84380
-----------------------------------------------------------

Ship it!



src/lib/marble/osm/OsmRelationManagerWidget.cpp (line 61)
<https://git.reviewboard.kde.org/r/124822/#comment58428>

    don't we have to return here like before also, and delete the editor later on in any case?



src/lib/marble/osm/OsmRelationManagerWidget.cpp (line 145)
<https://git.reviewboard.kde.org/r/124822/#comment58429>

    see above



src/lib/marble/osm/OsmRelationManagerWidget_p.cpp (line 115)
<https://git.reviewboard.kde.org/r/124822/#comment58430>

    logic reversed, see other review
    `Q_ASSERT(m_allRelations);`


- Dennis Nienhüser


On Aug. 25, 2015, 9:10 p.m., Marius Stanciu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124822/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2015, 9:10 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> !!Integrating this ui to the annotate plugin is coming in a separate patch; These are just the classes.
> 
> The widget is used to view and edit relations for any placemark within the annotatePlugin
> A tab will be added to all the editors in the annotatePlugin ( EditPlacemarkDialog, EditPolygonDialog, EditPolylineDialog ).
> This will allow to include any placemark as a member to any existent( or newly created ) relations.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/osm/OsmRelationManagerWidget_p.cpp PRE-CREATION 
>   src/lib/marble/osm/OsmRelationManagerWidget_p.h PRE-CREATION 
>   src/lib/marble/osm/OsmRelationManagerWidget.ui PRE-CREATION 
>   src/lib/marble/osm/OsmRelationManagerWidget.cpp PRE-CREATION 
>   src/lib/marble/osm/OsmRelationManagerWidget.h PRE-CREATION 
>   src/lib/marble/osm/OsmRelationEditorDialog.cpp PRE-CREATION 
>   src/lib/marble/osm/OsmRelationEditorDialog.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124822/diff/
> 
> 
> Testing
> -------
> 
> created new placemarks, added them to relations. Created relations, modified them, removed them. Seems to work fine.
> 
> 
> Thanks,
> 
> Marius Stanciu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150826/076a1b6f/attachment.html>