[Marble-devel] Review Request 124822: gsoc: Introduces custom relation editing to placemarks within the AnnotatePlugin

Marius Stanciu stanciumarius94 at gmail.com
Tue Aug 25 21:10:57 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124822/
-----------------------------------------------------------

(Updated Aug. 25, 2015, 9:10 p.m.)


Review request for Marble.


Changes
-------

Fixed issues


Repository: marble


Description
-------

!!Integrating this ui to the annotate plugin is coming in a separate patch; These are just the classes.

The widget is used to view and edit relations for any placemark within the annotatePlugin
A tab will be added to all the editors in the annotatePlugin ( EditPlacemarkDialog, EditPolygonDialog, EditPolylineDialog ).
This will allow to include any placemark as a member to any existent( or newly created ) relations.


Diffs (updated)
-----

  src/lib/marble/osm/OsmRelationManagerWidget_p.cpp PRE-CREATION 
  src/lib/marble/osm/OsmRelationManagerWidget_p.h PRE-CREATION 
  src/lib/marble/osm/OsmRelationManagerWidget.ui PRE-CREATION 
  src/lib/marble/osm/OsmRelationManagerWidget.cpp PRE-CREATION 
  src/lib/marble/osm/OsmRelationManagerWidget.h PRE-CREATION 
  src/lib/marble/osm/OsmRelationEditorDialog.cpp PRE-CREATION 
  src/lib/marble/osm/OsmRelationEditorDialog.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124822/diff/


Testing
-------

created new placemarks, added them to relations. Created relations, modified them, removed them. Seems to work fine.


Thanks,

Marius Stanciu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150825/abaf6488/attachment-0001.html>


More information about the Marble-devel mailing list