[Marble-devel] Review Request 124781: gsoc: integrates the OsmTagEditorWidget and OsmRelationManagerWidget to the annotate editors

[Marius Stanciu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124781/
-----------------------------------------------------------

(Updated Aug. 19, 2015, 5:07 p.m.)


Review request for Marble.


Changes
-------

added the osmrelationmanagerwidget as well


Summary (updated)
-----------------

gsoc: integrates the OsmTagEditorWidget and OsmRelationManagerWidget to the annotate editors


Repository: marble


Description (updated)
-------

!! This file has the CMakeList diff for all the previous patches that weren't added to the CMake


===TagEditor===
Tags can now be edited for text, polyline and polygon annotations.
The style changing occurs in the following manner:

Text annotations:

If the icon link is empty, an icon is chosen from the current tags ( if available )
If the icon link is not empty, the custom icon is used.

Polylines and polygons:

If the default style is initialized( #polygon and #polyline ) and there is a tag-based style available, the tag-based style is used.
If the style is not default, then the custom one is used.

===RelationEditor===
The annotate plugin keeps a hash of all the relations loaded( from parsing, newly created relations )
Relations from this list are suggested in the Relations tab for all placemarks.

Normal use case:
1) Create a placemark
2) Add a new relation in the Relations tab
3) Create a new placemark
4) Add the relation created eariler for this placemark as well

Done! A relation with two members has been created


This might not be the final behaviour. Please do suggest a better rendering behaviour!


!TODO: gotta modify the parser and the writer to deal with these relations ( they can't be imported/exported atm ). Will do this in the next patch.


Diffs (updated)
-----

  src/lib/marble/EditPlacemarkDialog.h 1ff59c2 
  src/lib/marble/EditPlacemarkDialog.cpp ef295bb 
  src/lib/marble/FileViewWidget.cpp b1c77c7 
  src/lib/marble/TourItemDelegate.cpp 834f1a7 
  src/lib/marble/osm/CMakeLists.txt 2aa67f7 
  src/plugins/render/annotate/AnnotatePlugin.h dd29ee6 
  src/plugins/render/annotate/AnnotatePlugin.cpp e98043b 
  src/plugins/render/annotate/EditPolygonDialog.h 6c58caa 
  src/plugins/render/annotate/EditPolygonDialog.cpp 28815a5 
  src/plugins/render/annotate/EditPolylineDialog.h ae9177f 
  src/plugins/render/annotate/EditPolylineDialog.cpp bacc6df 

Diff: https://git.reviewboard.kde.org/r/124781/diff/


Testing (updated)
-------

Created placemarks, polylines, polygons, added tags, removed tags, changed styles... works as expected.
Created placemarks, created relations, added placemarks to relations, removed relations, edited relations.... works as expected.


Thanks,

Marius Stanciu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150819/6da2876f/attachment-0001.html>