[Marble-devel] Review Request 124781: gsoc: integrates the OsmTagEditorWidget ui in the annotate plugin tools

[Marius Stanciu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124781/
-----------------------------------------------------------

Review request for Marble.


Repository: marble


Description
-------

Tags can now be edited for text, polyline and polygon annotations.

The style changing occurs in the following manner:

Text annotations:

If the icon link is empty, an icon is chosen from the current tags ( if available )
If the icon link is not empty, the custom icon is used.


Polylines and polygons:

If the default style is initialized( #polygon and #polyline ) and there is a tag-based style available, the tag-based style is used.
If the style is not default, then the custom one is used.

This might not be the final behaviour. Please do suggest a better rendering behaviour!


Diffs
-----

  src/plugins/render/annotate/EditPolylineDialog.ui 7bd3103 
  src/plugins/render/annotate/EditPolylineDialog.cpp bacc6df 
  src/lib/marble/EditPlacemarkDialog.cpp ef295bb 
  src/plugins/render/annotate/EditPolygonDialog.cpp 28815a5 

Diff: https://git.reviewboard.kde.org/r/124781/diff/


Testing
-------

Created placemarks, polylines, polygons, added tags, removed tags, changed styles... works as expected.


Thanks,

Marius Stanciu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150816/41be7b4e/attachment.html>