[Marble-devel] Review Request 124775: gsoc: additional accesors and function name refactoring for the OsmPlacemarkData class

Marius Stanciu stanciumarius94 at gmail.com
Sun Aug 16 17:04:58 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124775/
-----------------------------------------------------------

(Updated Aug. 16, 2015, 5:04 p.m.)


Status
------

This change has been marked as submitted.


Review request for Marble.


Changes
-------

Submitted with commit 13ec0aebbf64d201f8ae2f00e37067cb3b37521e by Marius Stanciu to branch master.


Repository: marble


Description
-------

changed the generic named functions:
  reference ----> nodeReference, memberReference
  addReference ----> addNodeReference, addMemberReference

added the functions:
  removeNodeReference, removeMemberReference
  changeNodeReference
  removeTag, containsTag, containsTagKey


Diffs
-----

  src/lib/marble/osm/OsmPlacemarkData.h b73a6a0 
  src/lib/marble/osm/OsmPlacemarkData.cpp 5665ce5 
  src/plugins/runner/osm/OsmObjectManager.cpp 8bebf0c 
  src/plugins/runner/osm/handlers/OsmMemberTagHandler.cpp 80651c2 
  src/plugins/runner/osm/handlers/OsmNdTagHandler.cpp df102d0 
  src/plugins/runner/osm/translators/OsmDocumentTagTranslator.cpp 3591b6d 
  src/plugins/runner/osm/writers/OsmRelationTagWriter.cpp 82bbc8c 
  src/plugins/runner/osm/writers/OsmWayTagWriter.cpp ea534bb 

Diff: https://git.reviewboard.kde.org/r/124775/diff/


Testing
-------

usual importing->exporting->reimporting, everything works as expected


Thanks,

Marius Stanciu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150816/1da5f225/attachment.html>


More information about the Marble-devel mailing list