[Marble-devel] Review Request 124775: gsoc: additional accesors and function name refactoring for the OsmPlacemarkData class

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124775/#review83890
-----------------------------------------------------------

Ship it!



src/lib/marble/osm/OsmPlacemarkData.h (line 172)
<https://git.reviewboard.kde.org/r/124775/#comment58113>

    We might also call it `isNull` which a couple of Qt classes use to distinguish default constructed instances from other ones.


- Dennis Nienhüser


On Aug. 16, 2015, 3:20 p.m., Marius Stanciu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124775/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2015, 3:20 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> changed the generic named functions:
>   reference ----> nodeReference, memberReference
>   addReference ----> addNodeReference, addMemberReference
> 
> added the functions:
>   removeNodeReference, removeMemberReference
>   changeNodeReference
>   removeTag, containsTag, containsTagKey
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/osm/OsmPlacemarkData.h b73a6a0 
>   src/lib/marble/osm/OsmPlacemarkData.cpp 5665ce5 
>   src/plugins/runner/osm/OsmObjectManager.cpp 8bebf0c 
>   src/plugins/runner/osm/handlers/OsmMemberTagHandler.cpp 80651c2 
>   src/plugins/runner/osm/handlers/OsmNdTagHandler.cpp df102d0 
>   src/plugins/runner/osm/translators/OsmDocumentTagTranslator.cpp 3591b6d 
>   src/plugins/runner/osm/writers/OsmRelationTagWriter.cpp 82bbc8c 
>   src/plugins/runner/osm/writers/OsmWayTagWriter.cpp ea534bb 
> 
> Diff: https://git.reviewboard.kde.org/r/124775/diff/
> 
> 
> Testing
> -------
> 
> usual importing->exporting->reimporting, everything works as expected
> 
> 
> Thanks,
> 
> Marius Stanciu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150816/955594c9/attachment-0001.html>