[Marble-devel] Review Request 124519: Jump to current location button for Marble Maps

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124519/#review83390
-----------------------------------------------------------


The patch does not apply, it contains some changes that are already in master. How did you generate it? One way how this could happen is when you work on a branch, update it with the latest changes from master, and then create the diff using `git diff master` where master is the local, not yet updated master. If that wild guess is right, run `git diff origin/master` instead.

- Dennis Nienhüser


On Aug. 3, 2015, 4:07 p.m., Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124519/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2015, 4:07 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch introduces the CircleButton qml type. Based on this there is a button now which navigates the map at the current position.
> 
> 
> Diffs
> -----
> 
>   data/android/drawable-xxxhdpi/backdrop.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/gps_fixed.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/gps_not_fixed.png PRE-CREATION 
>   src/plugins/positionprovider/qtpositioning/QtPositioningPositionProviderPlugin.cpp 1a11d67fba96f328a0a5aba7545fa4e93c597964 
>   src/lib/marble/declarative/SearchBackend.cpp 05b768c5b2ec3cd549e3242cefaee2faaa423a53 
>   src/lib/marble/declarative/SearchBackend.h e320c484ff548bc678cc46fa13490af48718002a 
>   src/lib/marble/declarative/Routing.cpp 078cbd6d64191bebf2dc3255986433c6a4503743 
>   src/lib/marble/declarative/Routing.h 659f0120399197a3607acfbe874832da93687a09 
>   src/lib/marble/declarative/RouteRequestModel.cpp e23c9e12caf2d1f388f32f396cc4a404b7b490d3 
>   src/lib/marble/declarative/RouteRequestModel.h ba05435840d2558e847e1ffce85755fd5384660b 
>   src/lib/marble/declarative/MarbleQuickItem.cpp 28f599c3b51c7bf993e40c6c97265f351fe02f17 
>   src/lib/marble/declarative/MarbleQuickItem.h cca329761f23cd72315df2d359166a2cbfa8056c 
>   src/lib/marble/declarative/MarbleDeclarativePlugin.cpp 4f195ee1d4e4ab146a32c4c88513c4b80c938a67 
>   src/lib/marble/PluginManager.cpp 5cc47b247c0e10329d6694e0b29fb1029145dd90 
>   src/apps/marble-touch/MainWidget.qml 2ce63121caab5ae71c8655a9f3b967d9e456d549 
>   src/apps/marble-maps/Search.qml d30df076fb257ccfea917cba874df9e44caa956f 
>   src/apps/marble-maps/PositionButton.qml PRE-CREATION 
>   src/apps/marble-maps/MarbleMaps.qrc 2978e72c2fd12fe8435cfb3d5e5559982b41b110 
>   src/apps/marble-maps/MainScreen.qml ce36f04c61764c7d813608f3bb7aeb671731c5a4 
>   src/apps/marble-maps/CircularButton.qml PRE-CREATION 
>   src/apps/marble-maps/BoxedText.qml PRE-CREATION 
>   data/android/drawable-xxxhdpi/marblelogo.png bf462f7608169f70cc014d8da1e0ad86e11bed15 
> 
> Diff: https://git.reviewboard.kde.org/r/124519/diff/
> 
> 
> Testing
> -------
> 
> It seems my distance or angle functions are not working well, the almost always provide false data after some panning (my position is sometimes start to change when I am panning on the map, strange thing: the position marker also starts to go to an other place like it is fixed to the screen, but the map moves under it sometimes when I am penning and it is not jumping back to its place.)
> 
> 
> File Attachments
> ----------------
> 
> gps_not_fixed.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/30/35409caf-2dbd-4fc4-b495-43fe1d8e4279__gps_not_fixed.png
> gps_fixed.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/30/019abdbb-80cf-4935-8d6d-0c3e6927d2b3__gps_fixed.png
> marblelogo.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/31/ebaa4d45-b337-4e42-8a23-a73e2d88ddca__marblelogo.png
> backdrop.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/31/dacf5958-7270-40c4-9031-243350a80de8__backdrop.png
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150803/fc019fe6/attachment-0001.html>